public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: utils: build with -Wimplicit-fallthrough=4 -Werror
Date: Fri,  7 Aug 2020 13:16:34 +0000 (GMT)	[thread overview]
Message-ID: <20200807131634.617A5385ED4D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=acfed1364a36e7d66cb77fa0476de45041df039a

commit acfed1364a36e7d66cb77fa0476de45041df039a
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Fri Aug 7 13:31:38 2020 +0200

    Cygwin: utils: build with -Wimplicit-fallthrough=4 -Werror
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/utils/Makefile.in | 4 +++-
 winsup/utils/ssp.c       | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/winsup/utils/Makefile.in b/winsup/utils/Makefile.in
index 6bf4454c5..248939645 100644
--- a/winsup/utils/Makefile.in
+++ b/winsup/utils/Makefile.in
@@ -14,9 +14,11 @@ configure_args=@configure_args@
 export CC:=@CC@
 export CXX:=@CXX@
 
+CFLAGS_COMMON=-Wimplicit-fallthrough=4 -Werror
 CFLAGS:=@CFLAGS@
 CXXFLAGS:=@CXXFLAGS@
-override CXXFLAGS+=-fno-exceptions -fno-rtti
+override CFLAGS+=${CFLAGS_COMMON}
+override CXXFLAGS+=-fno-exceptions -fno-rtti ${CFLAGS_COMMON}
 
 include ${srcdir}/../Makefile.common
 
diff --git a/winsup/utils/ssp.c b/winsup/utils/ssp.c
index 779b31775..4c98eefa9 100644
--- a/winsup/utils/ssp.c
+++ b/winsup/utils/ssp.c
@@ -465,7 +465,7 @@ run_program (char *cmdline)
 		      thread_return_address[tix] = rv;
 		}
 	      set_step_threads (event.dwThreadId, stepping_enabled);
-	      /* fall-through */
+	      /*FALLTHRU*/
 	    case STATUS_SINGLE_STEP:
 	      opcode_count++;
 	      pc = (CONTEXT_REG)event.u.Exception.ExceptionRecord.ExceptionAddress;


                 reply	other threads:[~2020-08-07 13:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200807131634.617A5385ED4D@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).