From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kbrown@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2210)
 id 99E183858026; Mon,  7 Dec 2020 21:33:43 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99E183858026
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Ken Brown <kbrown@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: dtable::dup_worker: update comment and debug
 output
X-Act-Checkin: newlib-cygwin
X-Git-Author: Ken Brown <kbrown@cornell.edu>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: 9e573ba50f129bff7b6e1be10cf4bbcb70f1efdd
X-Git-Newrev: b6624e23e17bdc505f639d9f181225dbf3a50fc6
Message-Id: <20201207213343.99E183858026@sourceware.org>
Date: Mon,  7 Dec 2020 21:33:43 +0000 (GMT)
X-BeenThere: cygwin-cvs@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component git logs <cygwin-cvs.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-cvs/>
List-Help: <mailto:cygwin-cvs-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2020 21:33:43 -0000

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b6624e23e17bdc505f639d9f181225dbf3a50fc6

commit b6624e23e17bdc505f639d9f181225dbf3a50fc6
Author: Ken Brown <kbrown@cornell.edu>
Date:   Mon Dec 7 16:19:57 2020 -0500

    Cygwin: dtable::dup_worker: update comment and debug output
    
    The comment and debug output became obsolete in commit 23771fa1f7 when
    dup_worker started calling fhandler_base::clone instead of build_fh_pc
    and fhandler_base::operator=.

Diff:
---
 winsup/cygwin/dtable.cc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc
index 6a91e33bc..9f4210797 100644
--- a/winsup/cygwin/dtable.cc
+++ b/winsup/cygwin/dtable.cc
@@ -679,12 +679,9 @@ out:
 fhandler_base *
 dtable::dup_worker (fhandler_base *oldfh, int flags)
 {
-  /* Don't call set_name in build_fh_pc.  It will be called in
-     fhandler_base::operator= below.  Calling it twice will result
-     in double allocation. */
   fhandler_base *newfh = oldfh->clone ();
   if (!newfh)
-    debug_printf ("build_fh_pc failed");
+    debug_printf ("clone failed");
   else
     {
       if (!oldfh->archetype)