public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Ken Brown <kbrown@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: fchmodat: add limited support for AT_SYMLINK_NOFOLLOW Date: Fri, 29 Jan 2021 16:51:40 +0000 (GMT) [thread overview] Message-ID: <20210129165140.23C85393D000@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=883abd9d7d51ca3cd089acda5917f9fb80a85745 commit 883abd9d7d51ca3cd089acda5917f9fb80a85745 Author: Ken Brown <kbrown@cornell.edu> Date: Tue Jan 26 15:54:05 2021 -0500 Cygwin: fchmodat: add limited support for AT_SYMLINK_NOFOLLOW Allow fchmodat with the AT_SYMLINK_NOFOLLOW flag to succeed on non-symlinks. Previously it always failed, as it does on Linux. But POSIX permits it to succeed on non-symlinks even if it fails on symlinks. The reason for following POSIX rather than Linux is to make gnulib report that fchmodat works on Cygwin. This improves the efficiency of packages like GNU tar that use gnulib's fchmodat module. Previously such packages would use a gnulib replacement for fchmodat on Cygwin. Diff: --- winsup/cygwin/syscalls.cc | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 8bb6ebae7..82ddad46d 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -4787,17 +4787,27 @@ fchmodat (int dirfd, const char *pathname, mode_t mode, int flags) tmp_pathbuf tp; __try { - if (flags) + if (flags & ~AT_SYMLINK_NOFOLLOW) { - /* BSD has lchmod, but Linux does not. POSIX says - AT_SYMLINK_NOFOLLOW is allowed to fail on symlinks; but Linux - blindly fails even for non-symlinks. */ - set_errno ((flags & ~AT_SYMLINK_NOFOLLOW) ? EINVAL : EOPNOTSUPP); + set_errno (EINVAL); __leave; } char *path = tp.c_get (); if (gen_full_path_at (path, dirfd, pathname)) __leave; + if (flags & AT_SYMLINK_NOFOLLOW) + { + /* BSD has lchmod, but Linux does not. POSIX says + AT_SYMLINK_NOFOLLOW is allowed to fail on symlinks. + Linux blindly fails even for non-symlinks, but we allow + it to succeed. */ + path_conv pc (path, PC_SYM_NOFOLLOW, stat_suffixes); + if (pc.issymlink ()) + { + set_errno (EOPNOTSUPP); + __leave; + } + } return chmod (path, mode); } __except (EFAULT) {}
reply other threads:[~2021-01-29 16:51 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210129165140.23C85393D000@sourceware.org \ --to=kbrown@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).