public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Ken Brown <kbrown@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: getdtablesize: always return OPEN_MAX_MAX
Date: Mon,  1 Feb 2021 14:58:54 +0000 (GMT)	[thread overview]
Message-ID: <20210201145854.117DE386F008@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=3d256e22e22d435d13cfecf39c15338cfbd6f587

commit 3d256e22e22d435d13cfecf39c15338cfbd6f587
Author: Ken Brown <kbrown@cornell.edu>
Date:   Wed Jan 27 20:06:22 2021 -0500

    Cygwin: getdtablesize: always return OPEN_MAX_MAX
    
    According to the Linux man page for getdtablesize(3), the latter is
    supposed to return "the maximum number of files a process can have
    open, one more than the largest possible value for a file descriptor."
    The constant OPEN_MAX_MAX is the only limit enforced by Cygwin, so we
    now return that.
    
    Previously getdtablesize returned the current size of cygheap->fdtab,
    Cygwin's internal file descriptor table.  But this is a dynamically
    growing table, and its current size does not reflect an actual limit
    on the number of open files.
    
    With this change, gnulib now reports that getdtablesize and
    fcntl(F_DUPFD) work on Cygwin.  Packages like GNU tar that use the
    corresponding gnulib modules will no longer use gnulib replacements on
    Cygwin.

Diff:
---
 winsup/cygwin/syscalls.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index 82ddad46d..d293ff2c0 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -2887,7 +2887,7 @@ setdtablesize (int size)
 extern "C" int
 getdtablesize ()
 {
-  return cygheap->fdtab.size;
+  return OPEN_MAX_MAX;
 }
 
 extern "C" int


                 reply	other threads:[~2021-02-01 14:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201145854.117DE386F008@sourceware.org \
    --to=kbrown@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).