From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id A4AD53851C07; Wed, 10 Feb 2021 09:51:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4AD53851C07 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: don't copy path_conv in fhandler_base::reset X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: 89b3833211a850a165a3c844acb19a66524c3cc2 X-Git-Newrev: c875ed3744968b19f7dd8ed6335710be55617d36 Message-Id: <20210210095157.A4AD53851C07@sourceware.org> Date: Wed, 10 Feb 2021 09:51:57 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 09:51:57 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=c875ed3744968b19f7dd8ed6335710be55617d36 commit c875ed3744968b19f7dd8ed6335710be55617d36 Author: Corinna Vinschen Date: Wed Feb 10 10:33:36 2021 +0100 Cygwin: don't copy path_conv in fhandler_base::reset There's a slim chance that duplicating fhandlers may end up duplicating path_conv_handle handles twice ending up with a handle leak, due to fhandler_base::reset calling path_conv::operator<< after the only caller, fhandler::copyto, already called path_conv::operator=. Just drop the call which basically duplicates what path_conv::operator= already did. Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/fhandler.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc index 5dbbd4068..ee0047ea0 100644 --- a/winsup/cygwin/fhandler.cc +++ b/winsup/cygwin/fhandler.cc @@ -43,7 +43,6 @@ LONG NO_COPY fhandler_base_overlapped::asio_close_counter; void fhandler_base::reset (const fhandler_base *from) { - pc << from->pc; ra.rabuf = NULL; ra.ralen = 0; ra.raixget = 0;