From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id BED54389682E; Mon, 22 Feb 2021 13:58:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BED54389682E Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: console: Prevent NULL pointer access in close(). X-Act-Checkin: newlib-cygwin X-Git-Author: Takashi Yano via Cygwin-patches X-Git-Refname: refs/heads/master X-Git-Oldrev: 18b91fbe580e747edf0f7ef8edbec4df07bc7245 X-Git-Newrev: 6cde7279a00452ed1ccc0ffc39d9011b016fadb3 Message-Id: <20210222135819.BED54389682E@sourceware.org> Date: Mon, 22 Feb 2021 13:58:19 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 13:58:19 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6cde7279a00452ed1ccc0ffc39d9011b016fadb3 commit 6cde7279a00452ed1ccc0ffc39d9011b016fadb3 Author: Takashi Yano via Cygwin-patches Date: Mon Feb 22 22:30:17 2021 +0900 Cygwin: console: Prevent NULL pointer access in close(). - There seems to be a case that shared_console_info is not set yet when close() is called. This patch adds guard for such case. Diff: --- winsup/cygwin/fhandler_console.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc index 6ded9eabf..96a8729e8 100644 --- a/winsup/cygwin/fhandler_console.cc +++ b/winsup/cygwin/fhandler_console.cc @@ -1393,7 +1393,7 @@ fhandler_console::close () release_output_mutex (); - if (con.owner == myself->pid) + if (shared_console_info && con.owner == myself->pid) { char name[MAX_PATH]; shared_name (name, CONS_THREAD_SYNC, get_minor ());