From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id B38F73857C7B; Mon, 8 Mar 2021 09:34:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B38F73857C7B Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: console, pty: Stop ignoring Ctrl-C by IGNBRK. X-Act-Checkin: newlib-cygwin X-Git-Author: Takashi Yano via Cygwin-patches X-Git-Refname: refs/heads/master X-Git-Oldrev: 4e16e575db04b2d1f8af215bff299339348016f4 X-Git-Newrev: b92a6303f1d02d8b583cd6b0509a80da76c8e3ea Message-Id: <20210308093429.B38F73857C7B@sourceware.org> Date: Mon, 8 Mar 2021 09:34:29 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 09:34:29 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b92a6303f1d02d8b583cd6b0509a80da76c8e3ea commit b92a6303f1d02d8b583cd6b0509a80da76c8e3ea Author: Takashi Yano via Cygwin-patches Date: Sun Mar 7 10:41:11 2021 +0900 Cygwin: console, pty: Stop ignoring Ctrl-C by IGNBRK. - Perhaps current code misunderstand meaning of the IGNBRK. As far as I investigated, IGNBRK is concerned with break signal in serial port but there is no evidence that it has effect to ignore Ctrl-C. This patch stops ignoring Ctrl-C by IGNBRK for non-cygwin apps. Diff: --- winsup/cygwin/fhandler_console.cc | 2 +- winsup/cygwin/fhandler_tty.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc index 96a8729e8..0b33a1370 100644 --- a/winsup/cygwin/fhandler_console.cc +++ b/winsup/cygwin/fhandler_console.cc @@ -484,7 +484,7 @@ fhandler_console::set_input_mode (tty::cons_mode m, const termios *t, /* This is illegal, so turn off the echo here, and fake it when we read the characters */ flags &= ~ENABLE_ECHO_INPUT; - if ((t->c_lflag & ISIG) && !(t->c_iflag & IGNBRK)) + if (t->c_lflag & ISIG) flags |= ENABLE_PROCESSED_INPUT; break; } diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc index 244147a80..4358bceec 100644 --- a/winsup/cygwin/fhandler_tty.cc +++ b/winsup/cygwin/fhandler_tty.cc @@ -2165,8 +2165,8 @@ fhandler_pty_master::write (const void *ptr, size_t len) } WaitForSingleObject (input_mutex, INFINITE); - if ((ti.c_lflag & ISIG) && !(ti.c_iflag & IGNBRK) - && !(ti.c_lflag & NOFLSH) && memchr (buf, '\003', nlen)) + if ((ti.c_lflag & ISIG) && !(ti.c_lflag & NOFLSH) + && memchr (buf, '\003', nlen)) get_ttyp ()->discard_input = true; DWORD n; WriteFile (to_slave, buf, nlen, &n, NULL); @@ -3307,7 +3307,7 @@ skip_create: /* This is illegal, so turn off the echo here, and fake it when we read the characters */ mode &= ~ENABLE_ECHO_INPUT; - if ((t.c_lflag & ISIG) && !(t.c_iflag & IGNBRK)) + if (t.c_lflag & ISIG) mode |= ENABLE_PROCESSED_INPUT; SetConsoleMode (hpConIn, mode); /* Set output mode */