public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: revert handwritten tags/ctags target
Date: Thu,  6 May 2021 09:20:18 +0000 (GMT)	[thread overview]
Message-ID: <20210506092018.B4F393A64001@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=a5b24cb24156451ada08f3fd3e36b264792e85ea

commit a5b24cb24156451ada08f3fd3e36b264792e85ea
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Thu May 6 11:12:46 2021 +0200

    Cygwin: revert handwritten tags/ctags target
    
    Converting to automake dropped the former, handwritten tags/ctags
    target.  This leads to a couple of problems:
    
    - For no good reason the tags file gets written to the builddir
      instead of to the srcdir where it's needed.
    
    - `make tags' requires etags to exist, rather than checking if it
      exists and skipping it.
    
    - Adding the extra ctags arguments to AM_CTAGSFLAGS still results
      in a shortened tags file.
    
    (Temporary?) solution: Revert the old tags/ctags rules and silence
    the automake warnings.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/Makefile.am | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/winsup/cygwin/Makefile.am b/winsup/cygwin/Makefile.am
index 8cde3f452..f75a10bc0 100644
--- a/winsup/cygwin/Makefile.am
+++ b/winsup/cygwin/Makefile.am
@@ -8,6 +8,8 @@
 
 # This makefile requires GNU make.
 
+#AUTOMAKE_OPTIONS=-Wno-override
+
 include $(top_srcdir)/Makefile.am.common
 
 COMMON_CFLAGS=-Wimplicit-fallthrough=5 -Werror -fmerge-constants -ftracer
@@ -23,6 +25,10 @@ if TARGET_X86_64
 AM_CCASFLAGS=-D_WIN64
 endif
 
+AM_CTAGSFLAGS=-R -f $(srcdir)/tags --c++-kinds=+p --fields=+iaS --extra=+q \
+	--regex-C++='/EXPORT_ALIAS *\([a-zA-Z0-9_]*, *([a-zA-Z0-9_]*)\)/\1/' \
+	--regex-C++='/__ASMNAME *\("([a-zA-Z0-9_]+)"\)/\1/'
+
 target_builddir=@target_builddir@
 newlib_build=$(target_builddir)/newlib
 
@@ -769,3 +775,12 @@ uninstall-headers:
 
 uninstall-ldif:
 	rm -f $(DESTDIR)$(datarootdir)/cygwin/cygwin.ldif
+
+#ctags: CTAGS
+#tags:  CTAGS
+#CTAGS:
+#	-cd $(srcdir) && \
+#	ctags -R --c++-kinds=+p --fields=+iaS --extra=+q \
+#	--regex-C++='/EXPORT_ALIAS *\([a-zA-Z0-9_]*, *([a-zA-Z0-9_]*)\)/\1/' \
+#	--regex-C++='/__ASMNAME *\("([a-zA-Z0-9_]+)"\)/\1/' \
+#	.


                 reply	other threads:[~2021-05-06  9:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506092018.B4F393A64001@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).