From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 72DB7385741D; Thu, 20 May 2021 20:40:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72DB7385741D Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: utils: chattr: fix recursive behaviour X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: cb674a4ad14d90852f0d75d72ed110fcce5dea50 X-Git-Newrev: f8eecf22db118347da55c25c4f75890b9902fabc Message-Id: <20210520204000.72DB7385741D@sourceware.org> Date: Thu, 20 May 2021 20:40:00 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 20:40:00 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=f8eecf22db118347da55c25c4f75890b9902fabc commit f8eecf22db118347da55c25c4f75890b9902fabc Author: Corinna Vinschen Date: Thu May 20 22:32:34 2021 +0200 Cygwin: utils: chattr: fix recursive behaviour chattr [mode] dir incorrectly recurses one level into the given directory, even if the --recursive option has not been used. This patch adds a test to avoid this bug. Signed-off-by: Corinna Vinschen Diff: --- winsup/utils/chattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/utils/chattr.c b/winsup/utils/chattr.c index c7dc649c2..eb60e5d3e 100644 --- a/winsup/utils/chattr.c +++ b/winsup/utils/chattr.c @@ -347,7 +347,7 @@ next: { if (chattr (argv[optind])) ret = 1; - if (S_ISDIR (st.st_mode) && chattr_dir (argv[optind])) + if (S_ISDIR (st.st_mode) && Ropt && chattr_dir (argv[optind])) ret = 1; } }