public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: Ensure PSAPI_VERSION is 1 when building ldd
Date: Sat, 22 May 2021 15:07:12 +0000 (GMT)	[thread overview]
Message-ID: <20210522150712.CAD85387088D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=a9c8050c363cfaa959004231adad8456b4df5c32

commit a9c8050c363cfaa959004231adad8456b4df5c32
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Thu May 20 18:28:01 2021 +0100

    Cygwin: Ensure PSAPI_VERSION is 1 when building ldd
    
    The default PSAPI_VERSION is controlled by WIN32_WINNT, which we set to
    0x0a00 when building ldd, which gets PSAPI_VERSION=2.
    
    This causes K32GetModuleFileNameEx to be used for GetModuleFileNameEx,
    which isn't available on Windows Vista.
    
    Define PSAPI_VERSION as 1 for the built executable to work on Windows
    Vista.

Diff:
---
 winsup/utils/ldd.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/utils/ldd.cc b/winsup/utils/ldd.cc
index 183e02cd4..cc1349655 100644
--- a/winsup/utils/ldd.cc
+++ b/winsup/utils/ldd.cc
@@ -38,6 +38,7 @@
 #include <libgen.h>
 
 #define _WIN32_WINNT 0x0a00
+#define PSAPI_VERSION 1
 #include <windows.h>
 #include <winternl.h>
 #include <imagehlp.h>


                 reply	other threads:[~2021-05-22 15:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210522150712.CAD85387088D@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).