From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2155)
 id C60B63858D34; Mon, 30 Aug 2021 19:57:14 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C60B63858D34
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: dup: fix handle inheritence for disk file
 pread/pwrite handle
X-Act-Checkin: newlib-cygwin
X-Git-Author: Corinna Vinschen <corinna@vinschen.de>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: dcb515a95369508b7ca769e3c011e65ef14c80dc
X-Git-Newrev: 9069cb91710d55735af5115681712ba4c2894276
Message-Id: <20210830195714.C60B63858D34@sourceware.org>
Date: Mon, 30 Aug 2021 19:57:14 +0000 (GMT)
X-BeenThere: cygwin-cvs@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component git logs <cygwin-cvs.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-cvs/>
List-Help: <mailto:cygwin-cvs-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Mon, 30 Aug 2021 19:57:15 -0000

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=9069cb91710d55735af5115681712ba4c2894276

commit 9069cb91710d55735af5115681712ba4c2894276
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon Aug 30 21:56:33 2021 +0200

    Cygwin: dup: fix handle inheritence for disk file pread/pwrite handle
    
    The handle is created non-inheritable but gets inheritable when
    dup'ing the file descriptor.  Fix that.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler_disk_file.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_disk_file.cc b/winsup/cygwin/fhandler_disk_file.cc
index 6170427b0..33d885819 100644
--- a/winsup/cygwin/fhandler_disk_file.cc
+++ b/winsup/cygwin/fhandler_disk_file.cc
@@ -1444,7 +1444,7 @@ fhandler_disk_file::dup (fhandler_base *child, int flags)
   if (!ret && prw_handle
       && !DuplicateHandle (GetCurrentProcess (), prw_handle,
 			   GetCurrentProcess (), &fhc->prw_handle,
-			   0, TRUE, DUPLICATE_SAME_ACCESS))
+			   0, FALSE, DUPLICATE_SAME_ACCESS))
     fhc->prw_handle = NULL;
   return ret;
 }