public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: fix initializing MEM_EXTENDED_PARAMETER Date: Mon, 6 Sep 2021 18:29:48 +0000 (GMT) [thread overview] Message-ID: <20210906182948.E73623857036@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=3d322ac930ca6d2516680fc78e3d3018cc737483 commit 3d322ac930ca6d2516680fc78e3d3018cc737483 Author: Corinna Vinschen <corinna@vinschen.de> Date: Mon Sep 6 20:15:43 2021 +0200 Cygwin: fix initializing MEM_EXTENDED_PARAMETER MEM_EXTENDED_PARAMETER consists of a 64 bit bitfield which contains the Type and the Reserved members. The former usage of designated initializer lists initialized Type, but not Reserved. Since that's not possible anymore due to a g++ 11.2 bug, Cygwin initializes the MEM_EXTENDED_PARAMETER structs explicitely. This results in a random value in Reserved, which at least VirtualAlloc2 chokes on (ERROR_INVALID_PARAMETER). Set Reserved explicitely to 0 for a fix. Fixes: bdb7991db38b ("Cygwin: workaround a g++ 11.2 initialization bug") Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/miscfuncs.cc | 2 ++ winsup/cygwin/mmap.cc | 2 ++ 2 files changed, 4 insertions(+) diff --git a/winsup/cygwin/miscfuncs.cc b/winsup/cygwin/miscfuncs.cc index f4c3a1c48..b544e7125 100644 --- a/winsup/cygwin/miscfuncs.cc +++ b/winsup/cygwin/miscfuncs.cc @@ -519,6 +519,7 @@ class thread_allocator /* g++ 11.2 workaround: don't use initializer */ MEM_EXTENDED_PARAMETER thread_ext; thread_ext.Type = MemExtendedParameterAddressRequirements; + thread_ext.Reserved = 0; thread_ext.Pointer = (PVOID) &thread_req; SIZE_T real_size = roundup2 (size, THREAD_STACK_SLOT); @@ -540,6 +541,7 @@ class thread_allocator /* g++ 11.2 workaround: don't use initializer */ MEM_EXTENDED_PARAMETER mmap_ext; mmap_ext.Type = MemExtendedParameterAddressRequirements; + mmap_ext.Reserved = 0; mmap_ext.Pointer = (PVOID) &mmap_req; real_stackaddr = VirtualAlloc2 (GetCurrentProcess(), NULL, real_size, diff --git a/winsup/cygwin/mmap.cc b/winsup/cygwin/mmap.cc index 69c8c8990..2e202a047 100644 --- a/winsup/cygwin/mmap.cc +++ b/winsup/cygwin/mmap.cc @@ -209,6 +209,7 @@ MapView (HANDLE h, void *addr, size_t len, DWORD openflags, /* g++ 11.2 workaround: don't use initializer */ MEM_EXTENDED_PARAMETER mmap_ext; mmap_ext.Type = MemExtendedParameterAddressRequirements; + mmap_ext.Reserved = 0; mmap_ext.Pointer = (PVOID) &mmap_req; alloc_type |= attached (prot) ? MEM_RESERVE : 0; @@ -1629,6 +1630,7 @@ fhandler_dev_zero::mmap (caddr_t *addr, size_t len, int prot, /* g++ 11.2 workaround: don't use initializer */ MEM_EXTENDED_PARAMETER mmap_ext; mmap_ext.Type = MemExtendedParameterAddressRequirements; + mmap_ext.Reserved = 0; mmap_ext.Pointer = (PVOID) &mmap_req; base = VirtualAlloc2 (GetCurrentProcess(), *addr, len, alloc_type,
reply other threads:[~2021-09-06 18:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210906182948.E73623857036@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).