public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Revert "Cygwin: fhandler_pipe.cc:nt_select: fix flags again"
Date: Tue, 14 Sep 2021 15:05:34 +0000 (GMT)	[thread overview]
Message-ID: <20210914150534.347CF3857814@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=71f02bcc3f804395402134239c63484f0eaad04b

commit 71f02bcc3f804395402134239c63484f0eaad04b
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Tue Aug 31 11:39:49 2021 +0200

    Revert "Cygwin: fhandler_pipe.cc:nt_select: fix flags again"
    
    This reverts commit c35db324efb5cdc6605eac947e0d4fdeb45e8b43.

Diff:
---
 winsup/cygwin/fhandler_pipe.cc | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 81822a90b..b99f00c09 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -686,8 +686,10 @@ nt_create (LPSECURITY_ATTRIBUTES sa_ptr, PHANDLE r, PHANDLE w,
 				  npfsh, sa_ptr->lpSecurityDescriptor);
 
       timeout.QuadPart = -500000;
-      status = NtCreateNamedPipeFile (r, access, &attr, &io, 0, FILE_CREATE,
-				      0, pipe_type, FILE_PIPE_BYTE_STREAM_MODE,
+      status = NtCreateNamedPipeFile (r, access, &attr, &io,
+				      FILE_SHARE_READ | FILE_SHARE_WRITE,
+				      FILE_CREATE, FILE_SYNCHRONOUS_IO_NONALERT,
+				      pipe_type, FILE_PIPE_BYTE_STREAM_MODE,
 				      0, 1, psize, psize, &timeout);
 
       if (NT_SUCCESS (status))
@@ -736,7 +738,8 @@ nt_create (LPSECURITY_ATTRIBUTES sa_ptr, PHANDLE r, PHANDLE w,
       debug_printf ("NtOpenFile: name %S", &pipename);
 
       access = GENERIC_WRITE | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
-      status = NtOpenFile (w, access, &attr, &io, 0, 0);
+      status = NtOpenFile (w, access, &attr, &io, 0,
+			   FILE_SYNCHRONOUS_IO_NONALERT);
       if (!NT_SUCCESS (status))
 	{
 	  DWORD err = GetLastError ();


                 reply	other threads:[~2021-09-14 15:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914150534.347CF3857814@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).