public inbox for
help / color / mirror / Atom feed
From: Corinna Vinschen <>
Subject: [newlib-cygwin] Cygwin: pipes: always close read side pipe handle in error case
Date: Tue, 14 Sep 2021 15:05:59 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=b12cf6b3cf1557a73b899f8064389966e52d5949

commit b12cf6b3cf1557a73b899f8064389966e52d5949
Author: Corinna Vinschen <>
Date:   Fri Sep 3 10:25:29 2021 +0200

    Cygwin: pipes: always close read side pipe handle in error case
    Add missing CloseHandle.
    Signed-off-by: Corinna Vinschen <>

 winsup/cygwin/ | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 85ab3cf55..14f28f02c 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -608,6 +608,7 @@ fhandler_pipe::create (fhandler_pipe *fhs[2], unsigned psize, int mode)
   else if ((fhs[1] = (fhandler_pipe *) build_fh_dev (*pipew_dev)) == NULL)
       delete fhs[0];
+      CloseHandle (r);
       CloseHandle (w);

                 reply	other threads:[~2021-09-14 15:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).