public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: pipes: use NtClose when file has been opened with an NtXxx function
Date: Tue, 14 Sep 2021 15:06:04 +0000 (GMT)	[thread overview]
Message-ID: <20210914150604.607F03857800@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8efcee2500016a163b82bee94c542531676fc96b

commit 8efcee2500016a163b82bee94c542531676fc96b
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Fri Sep 3 10:31:27 2021 +0200

    Cygwin: pipes: use NtClose when file has been opened with an NtXxx function
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler_pipe.cc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 14f28f02c..8b66121b4 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -602,14 +602,14 @@ fhandler_pipe::create (fhandler_pipe *fhs[2], unsigned psize, int mode)
     __seterrno_from_win_error (ret);
   else if ((fhs[0] = (fhandler_pipe *) build_fh_dev (*piper_dev)) == NULL)
     {
-      CloseHandle (r);
-      CloseHandle (w);
+      NtClose (r);
+      NtClose (w);
     }
   else if ((fhs[1] = (fhandler_pipe *) build_fh_dev (*pipew_dev)) == NULL)
     {
       delete fhs[0];
-      CloseHandle (r);
-      CloseHandle (w);
+      NtClose (r);
+      NtClose (w);
     }
   else
     {
@@ -745,7 +745,7 @@ nt_create (LPSECURITY_ATTRIBUTES sa_ptr, PHANDLE r, PHANDLE w,
 	  DWORD err = GetLastError ();
 	  debug_printf ("NtOpenFile failed, r %p, %E", r);
 	  if (r)
-	    CloseHandle (*r);
+	    NtClose (*r);
 	  *w = NULL;
 	  return err;
 	}


                 reply	other threads:[~2021-09-14 15:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914150604.607F03857800@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).