From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2155)
 id 851AB3857818; Tue, 14 Sep 2021 15:06:29 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 851AB3857818
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: pipes: nt_create: set read handle to NULL in
 error case
X-Act-Checkin: newlib-cygwin
X-Git-Author: Corinna Vinschen <corinna@vinschen.de>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: ea9c0bbedcd43a6f7f90936e2626270e2c8e591a
X-Git-Newrev: 82643bd18e20ab55c7f5f16870934b0b2bf5c33b
Message-Id: <20210914150629.851AB3857818@sourceware.org>
Date: Tue, 14 Sep 2021 15:06:29 +0000 (GMT)
X-BeenThere: cygwin-cvs@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component git logs <cygwin-cvs.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-cvs/>
List-Help: <mailto:cygwin-cvs-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Tue, 14 Sep 2021 15:06:29 -0000

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=82643bd18e20ab55c7f5f16870934b0b2bf5c33b

commit 82643bd18e20ab55c7f5f16870934b0b2bf5c33b
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Fri Sep 3 10:59:02 2021 +0200

    Cygwin: pipes: nt_create: set read handle to NULL in error case
    
    Fix accidentally setting read handle to INVALID_HANDLE_VALUE in a
    single error case.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler_pipe.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 608c67c32..85730d039 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -811,7 +811,7 @@ nt_create (LPSECURITY_ATTRIBUTES sa_ptr, HANDLE &r, HANDLE &w,
 	    __seterrno_from_nt_status (status);
 	    err = GetLastError ();
 	    debug_printf ("failed, %E");
-	    r = INVALID_HANDLE_VALUE;
+	    r = NULL;
 	  }
 	}
     }