From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 88B443858434; Tue, 14 Sep 2021 15:06:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88B443858434 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: pipes: minor code cleanup X-Act-Checkin: newlib-cygwin X-Git-Author: Ken Brown X-Git-Refname: refs/heads/master X-Git-Oldrev: 82643bd18e20ab55c7f5f16870934b0b2bf5c33b X-Git-Newrev: 44693e80b1dd6f97a674ddd383521a21c09c6dad Message-Id: <20210914150634.88B443858434@sourceware.org> Date: Tue, 14 Sep 2021 15:06:34 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 15:06:34 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=44693e80b1dd6f97a674ddd383521a21c09c6dad commit 44693e80b1dd6f97a674ddd383521a21c09c6dad Author: Ken Brown Date: Fri Sep 3 09:42:00 2021 -0400 Cygwin: pipes: minor code cleanup Clarify a comment in raw_read, and remove a useless line from raw_write. Diff: --- winsup/cygwin/fhandler_pipe.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc index 85730d039..81b1aed5e 100644 --- a/winsup/cygwin/fhandler_pipe.cc +++ b/winsup/cygwin/fhandler_pipe.cc @@ -248,8 +248,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len) WaitForSingleObject (read_mtx, INFINITE); - /* Make sure never to request more bytes than half the pipe - buffer size. Every pending read lowers WriteQuotaAvailable + /* If the pipe is empty, don't request more bytes than half the + pipe buffer size. Every pending read lowers WriteQuotaAvailable on the write side and thus affects select's ability to return more or less reliable info whether a write succeeds or not. @@ -425,7 +425,6 @@ fhandler_pipe::raw_write (const void *ptr, size_t len) set_errno (EBADF); else __seterrno (); - len = (size_t) -1; } else if (NT_SUCCESS (status)) {