From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kbrown@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2210)
 id 7A89C3858412; Mon, 20 Sep 2021 19:10:34 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A89C3858412
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Ken Brown <kbrown@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: fhandler_pipe::open_setup: fail on error
 creating mutexes
X-Act-Checkin: newlib-cygwin
X-Git-Author: Ken Brown <kbrown@cornell.edu>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: e5fcb021cc9dcb1f19d45030457be86b4a226e65
X-Git-Newrev: 6fc0aa8e5d6cd7e344afc967d30253ed40541843
Message-Id: <20210920191034.7A89C3858412@sourceware.org>
Date: Mon, 20 Sep 2021 19:10:34 +0000 (GMT)
X-BeenThere: cygwin-cvs@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component git logs <cygwin-cvs.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-cvs/>
List-Help: <mailto:cygwin-cvs-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Mon, 20 Sep 2021 19:10:34 -0000

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6fc0aa8e5d6cd7e344afc967d30253ed40541843

commit 6fc0aa8e5d6cd7e344afc967d30253ed40541843
Author: Ken Brown <kbrown@cornell.edu>
Date:   Sat Sep 18 08:34:04 2021 -0400

    Cygwin: fhandler_pipe::open_setup: fail on error creating mutexes

Diff:
---
 winsup/cygwin/fhandler_pipe.cc | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 590ecf667..449e268ab 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -194,26 +194,39 @@ out:
 bool
 fhandler_pipe::open_setup (int flags)
 {
+  bool read_mtx_created = false;
+
   if (!fhandler_base::open_setup (flags))
     goto err;
   if (get_dev () == FH_PIPER && !read_mtx)
     {
       SECURITY_ATTRIBUTES *sa = sec_none_cloexec (flags);
       read_mtx = CreateMutex (sa, FALSE, NULL);
-      if (!read_mtx)
-	debug_printf ("CreateMutex read_mtx failed: %E");
+      if (read_mtx)
+	read_mtx_created = true;
+      else
+	{
+	  debug_printf ("CreateMutex read_mtx failed: %E");
+	  goto err;
+	}
     }
   if (!hdl_cnt_mtx)
     {
       SECURITY_ATTRIBUTES *sa = sec_none_cloexec (flags);
       hdl_cnt_mtx = CreateMutex (sa, FALSE, NULL);
       if (!hdl_cnt_mtx)
-	debug_printf ("CreateMutex hdl_cnt_mtx failed: %E");
+	{
+	  debug_printf ("CreateMutex hdl_cnt_mtx failed: %E");
+	  goto err_close_read_mtx;
+	}
     }
   if (get_dev () == FH_PIPEW && !query_hdl)
     set_pipe_non_blocking (is_nonblocking ());
   return true;
 
+err_close_read_mtx:
+  if (read_mtx_created)
+    CloseHandle (read_mtx);
 err:
   return false;
 }