From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2210) id 81690385841F; Mon, 20 Sep 2021 19:10:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81690385841F Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Ken Brown To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: make callers of open_setup check for failure X-Act-Checkin: newlib-cygwin X-Git-Author: Ken Brown X-Git-Refname: refs/heads/master X-Git-Oldrev: 6fc0aa8e5d6cd7e344afc967d30253ed40541843 X-Git-Newrev: be08c5c40b9224038ff5af9a033662752ce18ba7 Message-Id: <20210920191039.81690385841F@sourceware.org> Date: Mon, 20 Sep 2021 19:10:39 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2021 19:10:39 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=be08c5c40b9224038ff5af9a033662752ce18ba7 commit be08c5c40b9224038ff5af9a033662752ce18ba7 Author: Ken Brown Date: Sat Sep 18 09:10:23 2021 -0400 Cygwin: make callers of open_setup check for failure open_setup is called by dtable::init_std_file_from_handle and fhandler_base::open_with_arch. In both cases, failure of open_setup is now a fatal error. Currently this can only happen in the following situation: A Cygwin process is started by a non-Cygwin process, one of the standard IO handles is a pipe handle, and Cygwin is unable to create a required mutex (read_mtx or hdl_cnt_mtx). Diff: --- winsup/cygwin/dtable.cc | 3 ++- winsup/cygwin/fhandler.cc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc index a638a5995..d57cbb355 100644 --- a/winsup/cygwin/dtable.cc +++ b/winsup/cygwin/dtable.cc @@ -412,7 +412,8 @@ dtable::init_std_file_from_handle (int fd, HANDLE handle) fhp->set_pipe_buf_size (); } - fh->open_setup (openflags); + if (!fh->open_setup (openflags)) + api_fatal ("open_setup failed, %E"); fh->usecount = 0; cygheap->fdtab[fd] = fh; cygheap->fdtab[fd]->inc_refcnt (); diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc index 1af469e0c..36862c712 100644 --- a/winsup/cygwin/fhandler.cc +++ b/winsup/cygwin/fhandler.cc @@ -471,7 +471,8 @@ fhandler_base::open_with_arch (int flags, mode_t mode) archetype_usecount (1); usecount = 0; } - open_setup (flags); + if (!open_setup (flags)) + api_fatal ("open_setup failed, %E"); } close_on_exec (flags & O_CLOEXEC);