public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: drop support for systems not supporting the CONSOLE LOGON SID
Date: Fri, 29 Oct 2021 19:03:47 +0000 (GMT) [thread overview]
Message-ID: <20211029190347.E8501385780B@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=080eae709f41e9e5d194bcc59014cf1c03526ec4
commit 080eae709f41e9e5d194bcc59014cf1c03526ec4
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Fri Oct 29 18:17:00 2021 +0200
Cygwin: drop support for systems not supporting the CONSOLE LOGON SID
i. e. Vista/2008.
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/sec_auth.cc | 3 +--
winsup/cygwin/wincap.cc | 11 -----------
winsup/cygwin/wincap.h | 2 --
3 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/winsup/cygwin/sec_auth.cc b/winsup/cygwin/sec_auth.cc
index 83fb39bc5..9aae7c1d5 100644
--- a/winsup/cygwin/sec_auth.cc
+++ b/winsup/cygwin/sec_auth.cc
@@ -528,8 +528,7 @@ get_token_group_sidlist (cygsidlist &grp_list, PTOKEN_GROUPS my_grps)
if (my_grps)
{
grp_list += well_known_local_sid;
- if (wincap.has_console_logon_sid ())
- grp_list += well_known_console_logon_sid;
+ grp_list += well_known_console_logon_sid;
if (sid_in_token_groups (my_grps, well_known_dialup_sid))
grp_list *= well_known_dialup_sid;
if (sid_in_token_groups (my_grps, well_known_network_sid))
diff --git a/winsup/cygwin/wincap.cc b/winsup/cygwin/wincap.cc
index 63b0a261d..5c923277e 100644
--- a/winsup/cygwin/wincap.cc
+++ b/winsup/cygwin/wincap.cc
@@ -25,7 +25,6 @@ wincaps wincap_vista __attribute__((section (".cygwin_dll_common"), shared)) = {
is_server:false,
needs_query_information:true,
has_gaa_largeaddress_bug:true,
- has_console_logon_sid:false,
has_precise_system_time:false,
has_microsoft_accounts:false,
has_broken_prefetchvm:false,
@@ -57,7 +56,6 @@ wincaps wincap_7 __attribute__((section (".cygwin_dll_common"), shared)) = {
is_server:false,
needs_query_information:true,
has_gaa_largeaddress_bug:true,
- has_console_logon_sid:true,
has_precise_system_time:false,
has_microsoft_accounts:false,
has_broken_prefetchvm:false,
@@ -89,7 +87,6 @@ wincaps wincap_8 __attribute__((section (".cygwin_dll_common"), shared)) = {
is_server:false,
needs_query_information:true,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:false,
@@ -121,7 +118,6 @@ wincaps wincap_8_1 __attribute__((section (".cygwin_dll_common"), shared)) = {
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:false,
@@ -153,7 +149,6 @@ wincaps wincap_10_1507 __attribute__((section (".cygwin_dll_common"), shared))
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:true,
@@ -185,7 +180,6 @@ wincaps wincap_10_1607 __attribute__((section (".cygwin_dll_common"), shared))
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:true,
@@ -217,7 +211,6 @@ wincaps wincap_10_1703 __attribute__((section (".cygwin_dll_common"), shared)) =
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:false,
@@ -249,7 +242,6 @@ wincaps wincap_10_1709 __attribute__((section (".cygwin_dll_common"), shared)) =
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:false,
@@ -281,7 +273,6 @@ wincaps wincap_10_1803 __attribute__((section (".cygwin_dll_common"), shared)) =
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:false,
@@ -313,7 +304,6 @@ wincaps wincap_10_1809 __attribute__((section (".cygwin_dll_common"), shared)) =
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:false,
@@ -345,7 +335,6 @@ wincaps wincap_10_1903 __attribute__((section (".cygwin_dll_common"), shared)) =
is_server:false,
needs_query_information:false,
has_gaa_largeaddress_bug:false,
- has_console_logon_sid:true,
has_precise_system_time:true,
has_microsoft_accounts:true,
has_broken_prefetchvm:false,
diff --git a/winsup/cygwin/wincap.h b/winsup/cygwin/wincap.h
index 0d86a80e4..ba9a3b59d 100644
--- a/winsup/cygwin/wincap.h
+++ b/winsup/cygwin/wincap.h
@@ -19,7 +19,6 @@ struct wincaps
unsigned is_server : 1;
unsigned needs_query_information : 1;
unsigned has_gaa_largeaddress_bug : 1;
- unsigned has_console_logon_sid : 1;
unsigned has_precise_system_time : 1;
unsigned has_microsoft_accounts : 1;
unsigned has_broken_prefetchvm : 1;
@@ -83,7 +82,6 @@ public:
bool IMPLEMENT (is_server)
bool IMPLEMENT (needs_query_information)
bool IMPLEMENT (has_gaa_largeaddress_bug)
- bool IMPLEMENT (has_console_logon_sid)
bool IMPLEMENT (has_precise_system_time)
bool IMPLEMENT (has_microsoft_accounts)
bool IMPLEMENT (has_broken_prefetchvm)
reply other threads:[~2021-10-29 19:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029190347.E8501385780B@sourceware.org \
--to=corinna@sourceware.org \
--cc=cygwin-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).