public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: pipe: Avoid false EOF while reading output of C# programs.
@ 2021-11-08 10:07 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2021-11-08 10:07 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=365199090c05eb6076d0cfe9104a53177f6fa251
commit 365199090c05eb6076d0cfe9104a53177f6fa251
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date: Sun Nov 7 12:47:18 2021 +0900
Cygwin: pipe: Avoid false EOF while reading output of C# programs.
- If output of C# program is redirected to pipe, pipe reader falsely
detects EOF. This happens after overhaul of pipe implementation.
This patch fixes the issue.
Addresses:
https://cygwin.com/pipermail/cygwin/2021-November/249777.html
Diff:
---
winsup/cygwin/fhandler_pipe.cc | 3 ++-
winsup/cygwin/release/3.3.2 | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 43771e8f7..bc06d157c 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -393,7 +393,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len)
}
}
- if (nbytes_now == 0 || status == STATUS_BUFFER_OVERFLOW)
+ if ((nbytes_now == 0 && !NT_SUCCESS (status))
+ || status == STATUS_BUFFER_OVERFLOW)
break;
}
ReleaseMutex (read_mtx);
diff --git a/winsup/cygwin/release/3.3.2 b/winsup/cygwin/release/3.3.2
index 263c3efe6..2e48e39be 100644
--- a/winsup/cygwin/release/3.3.2
+++ b/winsup/cygwin/release/3.3.2
@@ -8,3 +8,7 @@ Bug Fixes
Addresses: https://sourceware.org/pipermail/newlib/2021/018626.html
- Fix a permission problem when writing ACLs on Samba.
+
+- Fix the issue that pipe reader falsely detects EOF if the output of
+ the C# program is redirected to the pipe.
+ Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249777.html
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-11-08 10:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-08 10:07 [newlib-cygwin] Cygwin: pipe: Avoid false EOF while reading output of C# programs Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).