From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 7BF183858401; Mon, 8 Nov 2021 10:07:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BF183858401 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: pipe: Avoid false EOF while reading output of C# programs. X-Act-Checkin: newlib-cygwin X-Git-Author: Takashi Yano X-Git-Refname: refs/heads/master X-Git-Oldrev: 873da400e080a233db74ad53b1d1fbabf0f15e65 X-Git-Newrev: 365199090c05eb6076d0cfe9104a53177f6fa251 Message-Id: <20211108100715.7BF183858401@sourceware.org> Date: Mon, 8 Nov 2021 10:07:15 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 10:07:15 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=365199090c05eb6076d0cfe9104a53177f6fa251 commit 365199090c05eb6076d0cfe9104a53177f6fa251 Author: Takashi Yano Date: Sun Nov 7 12:47:18 2021 +0900 Cygwin: pipe: Avoid false EOF while reading output of C# programs. - If output of C# program is redirected to pipe, pipe reader falsely detects EOF. This happens after overhaul of pipe implementation. This patch fixes the issue. Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249777.html Diff: --- winsup/cygwin/fhandler_pipe.cc | 3 ++- winsup/cygwin/release/3.3.2 | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc index 43771e8f7..bc06d157c 100644 --- a/winsup/cygwin/fhandler_pipe.cc +++ b/winsup/cygwin/fhandler_pipe.cc @@ -393,7 +393,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len) } } - if (nbytes_now == 0 || status == STATUS_BUFFER_OVERFLOW) + if ((nbytes_now == 0 && !NT_SUCCESS (status)) + || status == STATUS_BUFFER_OVERFLOW) break; } ReleaseMutex (read_mtx); diff --git a/winsup/cygwin/release/3.3.2 b/winsup/cygwin/release/3.3.2 index 263c3efe6..2e48e39be 100644 --- a/winsup/cygwin/release/3.3.2 +++ b/winsup/cygwin/release/3.3.2 @@ -8,3 +8,7 @@ Bug Fixes Addresses: https://sourceware.org/pipermail/newlib/2021/018626.html - Fix a permission problem when writing ACLs on Samba. + +- Fix the issue that pipe reader falsely detects EOF if the output of + the C# program is redirected to the pipe. + Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249777.html