public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Takashi Yano <tyan0@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/cygwin-3_3-branch] Cygwin: sigproc: Do not send signal to myself if exiting.
Date: Fri, 19 Nov 2021 17:40:54 +0000 (GMT)	[thread overview]
Message-ID: <20211119174054.57764385C411@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=67bf89c4cea3d41139328fd2d1494129f68fbbb1

commit 67bf89c4cea3d41139328fd2d1494129f68fbbb1
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Sat Nov 20 02:32:12 2021 +0900

    Cygwin: sigproc: Do not send signal to myself if exiting.
    
    - This patch fixes the issue that process sometimes hangs for 60
      seconds with the following scenario.
        1) Open command prompt.
        2) Run "c:\cygwin64\bin\bash -l"
        3) Compipe the following source with mingw compiler.
           /*--- Begin ---*/
           #include <stdio.h>
           int main() {return getchar();}
           /*---- End ----*/
        4) Run "tcsh -c ./a.exe"
        5) Hit Ctrl-C.

Diff:
---
 winsup/cygwin/sigproc.cc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
index dff797915..fde41a9f6 100644
--- a/winsup/cygwin/sigproc.cc
+++ b/winsup/cygwin/sigproc.cc
@@ -603,6 +603,11 @@ sig_send (_pinfo *p, siginfo_t& si, _cygtls *tls)
       its_me = false;
     }
 
+  /* Do not send signal to myself if exiting, which will be
+     ignored in wait_sig thread. */
+  if (its_me && exit_state > ES_EXIT_STARTING && si.si_signo > 0)
+    goto out;
+
   if (its_me)
     sendsig = my_sendsig;
   else


                 reply	other threads:[~2021-11-19 17:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119174054.57764385C411@sourceware.org \
    --to=tyan0@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).