public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/cygwin-3_3-branch] Cygwin: raise: align return value and error checking to Linux Date: Mon, 22 Nov 2021 11:52:03 +0000 (GMT) [thread overview] Message-ID: <20211122115203.82102385800A@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=71bc312fef620ce7444387e76f67a0448097635b commit 71bc312fef620ce7444387e76f67a0448097635b Author: Corinna Vinschen <corinna@vinschen.de> Date: Mon Nov 22 12:35:39 2021 +0100 Cygwin: raise: align return value and error checking to Linux raise(2) on Linux returns the same values and sets errno independent of calling kill(2) or pthread_kill(3). Align code to behave the same. Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/signal.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/signal.cc b/winsup/cygwin/signal.cc index f4b468664..2cf750f5c 100644 --- a/winsup/cygwin/signal.cc +++ b/winsup/cygwin/signal.cc @@ -303,7 +303,12 @@ raise (int sig) pthread *thread = _my_tls.tid; if (!thread || !__isthreaded) return kill (myself->pid, sig); - return pthread_kill (thread, sig); + + /* Make sure to return -1 and set errno, as on Linux. */ + int err = pthread_kill (thread, sig); + if (err) + set_errno (err); + return err ? -1 : 0; } static int
reply other threads:[~2021-11-22 11:52 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211122115203.82102385800A@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).