public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: raise: align return value and error checking to Linux
@ 2021-11-22 11:52 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2021-11-22 11:52 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=afb7c557d2af10cdcb16c7edcc9d16224995b9e0

commit afb7c557d2af10cdcb16c7edcc9d16224995b9e0
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon Nov 22 12:35:39 2021 +0100

    Cygwin: raise: align return value and error checking to Linux
    
    raise(2) on Linux returns the same values and sets errno
    independent of calling kill(2) or pthread_kill(3).  Align
    code to behave the same.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/signal.cc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/signal.cc b/winsup/cygwin/signal.cc
index f4b468664..2cf750f5c 100644
--- a/winsup/cygwin/signal.cc
+++ b/winsup/cygwin/signal.cc
@@ -303,7 +303,12 @@ raise (int sig)
   pthread *thread = _my_tls.tid;
   if (!thread || !__isthreaded)
     return kill (myself->pid, sig);
-  return pthread_kill (thread, sig);
+
+  /* Make sure to return -1 and set errno, as on Linux. */
+  int err = pthread_kill (thread, sig);
+  if (err)
+    set_errno (err);
+  return err ? -1 : 0;
 }
 
 static int


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-22 11:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 11:52 [newlib-cygwin] Cygwin: raise: align return value and error checking to Linux Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).