public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Takashi Yano <tyan0@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/cygwin-3_3-branch] Cygwin: pty: Fix Ctrl-C handling further for non-cygwin apps. Date: Mon, 13 Dec 2021 11:14:15 +0000 (GMT) [thread overview] Message-ID: <20211213111415.6FA91385840C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=f9bfc5f52c79d61dde8f84d0cbd7ad633abed4cb commit f9bfc5f52c79d61dde8f84d0cbd7ad633abed4cb Author: Takashi Yano <takashi.yano@nifty.ne.jp> Date: Mon Dec 13 19:25:22 2021 +0900 Cygwin: pty: Fix Ctrl-C handling further for non-cygwin apps. - The recent commit: "Cygwin: pty: Fix Ctrl-C handling for non-cygwin apps in background." causes the problem that cmd.exe is terminated by Ctrl-C even if it is running in pseudo console. This patch fixes the issue. Diff: --- winsup/cygwin/fhandler_tty.cc | 36 +++++++++++++++++++++++++++++++++++- winsup/cygwin/include/sys/cygwin.h | 2 ++ winsup/cygwin/spawn.cc | 3 +++ 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc index 7b18a15e7..5ec5b235d 100644 --- a/winsup/cygwin/fhandler_tty.cc +++ b/winsup/cygwin/fhandler_tty.cc @@ -2251,7 +2251,41 @@ fhandler_pty_master::write (const void *ptr, size_t len) if ((ti.c_lflag & ISIG) && memchr (buf, '\003', nlen)) { - get_ttyp ()->kill_pgrp (SIGINT); + /* If the process is started with CREATE_NEW_PROCESS_GROUP + flag, Ctrl-C will not be sent to that process. Therefore, + send Ctrl-break event to that process here. */ + DWORD wpid = 0; + winpids pids ((DWORD) 0); + for (unsigned i = 0; i < pids.npids; i++) + { + _pinfo *p = pids[i]; + if (p->ctty == get_ttyp ()->ntty + && p->pgid == get_ttyp ()->getpgid () + && (p->process_state & PID_NEW_PG)) + { + wpid = p->dwProcessId; + break; + } + } + pinfo pinfo_resume = pinfo (myself->ppid); + DWORD resume_pid; + if (pinfo_resume) + resume_pid = pinfo_resume->dwProcessId; + else + resume_pid = get_console_process_id (myself->dwProcessId, false); + if (wpid && resume_pid) + { + WaitForSingleObject (pcon_mutex, INFINITE); + FreeConsole (); + AttachConsole (wpid); + /* CTRL_C_EVENT does not work for the process started with + CREATE_NEW_PROCESS_GROUP flag, so send CTRL_BREAK_EVENT + instead. */ + GenerateConsoleCtrlEvent (CTRL_BREAK_EVENT, wpid); + FreeConsole (); + AttachConsole (resume_pid); + ReleaseMutex (pcon_mutex); + } if (!(ti.c_lflag & NOFLSH)) get_ttyp ()->discard_input = true; } diff --git a/winsup/cygwin/include/sys/cygwin.h b/winsup/cygwin/include/sys/cygwin.h index 805671ef9..ac55ab09c 100644 --- a/winsup/cygwin/include/sys/cygwin.h +++ b/winsup/cygwin/include/sys/cygwin.h @@ -274,6 +274,8 @@ enum PID_NEW = 0x01000, /* Available. */ PID_ALLPIDS = 0x02000, /* used by pinfo scanner */ PID_PROCINFO = 0x08000, /* caller just asks for process info */ + PID_NEW_PG = 0x10000, /* Process created with + CREATE_NEW_PROCESS_GROUOP flag */ PID_EXITED = 0x40000000, /* Free entry. */ PID_REAPED = 0x80000000 /* Reaped */ }; diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc index bea4d0194..b93063d9b 100644 --- a/winsup/cygwin/spawn.cc +++ b/winsup/cygwin/spawn.cc @@ -575,6 +575,9 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv, c_flags |= CREATE_NEW_PROCESS_GROUP; refresh_cygheap (); + if (c_flags & CREATE_NEW_PROCESS_GROUP) + myself->process_state |= PID_NEW_PG; + if (mode == _P_DETACH) /* all set */; else if (mode != _P_OVERLAY || !my_wr_proc_pipe)
reply other threads:[~2021-12-13 11:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211213111415.6FA91385840C@sourceware.org \ --to=tyan0@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).