public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/cygwin-3_3-branch] Cygwin: path_conv: do not get confused by a directory with `.lnk` suffix
Date: Tue, 18 Jan 2022 11:02:38 +0000 (GMT)	[thread overview]
Message-ID: <20220118110238.1A52F3857C4E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=7a8622667f479f58b61a4ecc49090ebb814c78bd

commit 7a8622667f479f58b61a4ecc49090ebb814c78bd
Author: Johannes Schindelin <johannes.schindelin@gmx.de>
Date:   Mon Jan 17 21:20:45 2022 +0100

    Cygwin: path_conv: do not get confused by a directory with `.lnk` suffix
    
    When trying to create a directory called `xyz` in the presence of a
    directory `xyz.lnk`, the Cygwin runtime errors out with an `ENOENT`.
    
    The root cause is actually a bit deeper: the `symlink_info::check()`
    method tries to figure out whether the given path refers to a symbolic
    link as emulated via `.lnk` files, but since it is a directory, that is
    not the case, and that hypothesis is rejected.
    
    However, the `fileattr` field is not cleared, so that a later
    `.exists()` call on the instance mistakenly thinks that the symlink
    actually exists. Let's clear that field.
    
    This fixes https://github.com/msys2/msys2-runtime/issues/81
    
    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Diff:
---
 winsup/cygwin/path.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
index 5ab75f105..87ac2404a 100644
--- a/winsup/cygwin/path.cc
+++ b/winsup/cygwin/path.cc
@@ -3336,6 +3336,7 @@ restart:
 	 hasn't been found. */
       if (ext_tacked_on && !had_ext && (fileattr & FILE_ATTRIBUTE_DIRECTORY))
 	{
+	  fileattr = INVALID_FILE_ATTRIBUTES;
 	  set_error (ENOENT);
 	  continue;
 	}


                 reply	other threads:[~2022-01-18 11:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118110238.1A52F3857C4E@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).