public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Takashi Yano <tyan0@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: fhandler_base: Fix double free caused when open() fails. Date: Tue, 18 Jan 2022 13:21:30 +0000 (GMT) [thread overview] Message-ID: <20220118132130.609253858438@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=ff539cc0f9ba4e52682a2647e4347ead4f2f8787 commit ff539cc0f9ba4e52682a2647e4347ead4f2f8787 Author: Takashi Yano <takashi.yano@nifty.ne.jp> Date: Tue Jan 18 22:17:37 2022 +0900 Cygwin: fhandler_base: Fix double free caused when open() fails. - When open fails, archetype stored in archetypes[] is not cleared. This causes double free when next open fail. This patch fixes the issue. Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250518.html Diff: --- winsup/cygwin/fhandler.cc | 4 ++-- winsup/cygwin/release/3.3.4 | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc index fc7c0422e..7d427135e 100644 --- a/winsup/cygwin/fhandler.cc +++ b/winsup/cygwin/fhandler.cc @@ -440,8 +440,8 @@ fhandler_base::open_with_arch (int flags, mode_t mode) if (!(res = (archetype && archetype->io_handle) || open (flags, mode & 07777))) { - if (archetype) - delete archetype; + if (archetype && archetype->usecount == 0) + cygheap->fdtab.delete_archetype (archetype); } else if (archetype) { diff --git a/winsup/cygwin/release/3.3.4 b/winsup/cygwin/release/3.3.4 index e09ffefdf..3fa9b9e9c 100644 --- a/winsup/cygwin/release/3.3.4 +++ b/winsup/cygwin/release/3.3.4 @@ -30,3 +30,6 @@ Bug Fixes - Fix a problem creating a dir "foo", if a file (but not a Cygwin symlink) "foo.lnk" already exists. Addresses: https://github.com/msys2/msys2-runtime/issues/81 + +- Fix double free for archetype, which is caused when open() fails. + Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250518.html
reply other threads:[~2022-01-18 13:21 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220118132130.609253858438@sourceware.org \ --to=tyan0@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).