public inbox for
help / color / mirror / Atom feed
From: Takashi Yano <>
Subject: [newlib-cygwin/cygwin-3_3-branch] Cygwin: fhandler_base: Fix double free caused when open() fails.
Date: Tue, 18 Jan 2022 13:22:06 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=f5d654c24e85f984ff34461934395b36fea2be0f

commit f5d654c24e85f984ff34461934395b36fea2be0f
Author: Takashi Yano <>
Date:   Tue Jan 18 22:17:37 2022 +0900

    Cygwin: fhandler_base: Fix double free caused when open() fails.
    - When open fails, archetype stored in archetypes[] is not cleared.
      This causes double free when next open fail. This patch fixes the

 winsup/cygwin/   | 4 ++--
 winsup/cygwin/release/3.3.4 | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index fc7c0422e..7d427135e 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -440,8 +440,8 @@ fhandler_base::open_with_arch (int flags, mode_t mode)
   if (!(res = (archetype && archetype->io_handle)
 	|| open (flags, mode & 07777)))
-      if (archetype)
-	delete archetype;
+      if (archetype && archetype->usecount == 0)
+	cygheap->fdtab.delete_archetype (archetype);
   else if (archetype)
diff --git a/winsup/cygwin/release/3.3.4 b/winsup/cygwin/release/3.3.4
index e09ffefdf..3fa9b9e9c 100644
--- a/winsup/cygwin/release/3.3.4
+++ b/winsup/cygwin/release/3.3.4
@@ -30,3 +30,6 @@ Bug Fixes
 - Fix a problem creating a dir "foo", if a file (but not a Cygwin symlink)
   "foo.lnk" already exists.
+- Fix double free for archetype, which is caused when open() fails.
+  Addresses:

                 reply	other threads:[~2022-01-18 13:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).