From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id A732C3858437; Thu, 27 Jan 2022 14:30:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A732C3858437 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/cygwin-3_3-branch] Revert "Cygwin: fix permission problem when writing DAC info on Samba shares" X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/cygwin-3_3-branch X-Git-Oldrev: 7d1e87cd76a920824507ff62164e8dbf3dcb8232 X-Git-Newrev: 7ac0767053e278f0ce9811bf6f77278bd2f49c20 Message-Id: <20220127143048.A732C3858437@sourceware.org> Date: Thu, 27 Jan 2022 14:30:48 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 14:30:48 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D7ac0767053e= 278f0ce9811bf6f77278bd2f49c20 commit 7ac0767053e278f0ce9811bf6f77278bd2f49c20 Author: Corinna Vinschen Date: Thu Jan 27 15:22:39 2022 +0100 Revert "Cygwin: fix permission problem when writing DAC info on Samba s= hares" =20 This reverts commit 0390cc85727b0165b5cdfcff7578cac94ae3371d. =20 There's no indication what exact situation this patch was supposed to solve, and local testing doesn't show any such problems. However, this patch itself introduced a new problem, as outlined by https://cygwin.com/pipermail/cygwin/2022-January/250629.html =20 Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/fhandler.cc | 6 ++---- winsup/cygwin/release/3.3.4 | 4 ++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc index 7d427135e..98d7a3b2d 100644 --- a/winsup/cygwin/fhandler.cc +++ b/winsup/cygwin/fhandler.cc @@ -561,12 +561,10 @@ fhandler_base::open (int flags, mode_t mode) access =3D READ_CONTROL | FILE_READ_ATTRIBUTES; break; case query_write_control: - access =3D READ_CONTROL | WRITE_OWNER | WRITE_DAC - | (pc.fs_is_samba () ? 0 : FILE_WRITE_ATTRIBUTES); + access =3D READ_CONTROL | WRITE_OWNER | WRITE_DAC | FILE_WRITE_ATTRI= BUTES; break; case query_write_dac: - access =3D READ_CONTROL | WRITE_DAC - | (pc.fs_is_samba () ? 0 : FILE_WRITE_ATTRIBUTES); + access =3D READ_CONTROL | WRITE_DAC | FILE_WRITE_ATTRIBUTES; break; case query_write_attributes: access =3D READ_CONTROL | FILE_WRITE_ATTRIBUTES; diff --git a/winsup/cygwin/release/3.3.4 b/winsup/cygwin/release/3.3.4 index d45722ac5..bc74e6914 100644 --- a/winsup/cygwin/release/3.3.4 +++ b/winsup/cygwin/release/3.3.4 @@ -33,3 +33,7 @@ Bug Fixes =20 - Fix double free for archetype, which is caused when open() fails. Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250518.html + +- Fix a permission problem when writing DOS attributes on Samba. + Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250629.html +