public inbox for
help / color / mirror / Atom feed
From: Takashi Yano <>
Subject: [newlib-cygwin] Cygwin: pty: Fix a bug in tty_min::segpgid().
Date: Sun, 13 Feb 2022 15:18:54 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=bed1add783a13b3304b1625b962707f89e90e323

commit bed1add783a13b3304b1625b962707f89e90e323
Author: Takashi Yano <>
Date:   Sun Feb 13 05:12:18 2022 +0900

    Cygwin: pty: Fix a bug in tty_min::segpgid().
    - In tty_min::setpgid(), a pointer to fhandler instance is casted to
      fhandler_pty_slave and accessed even if terminal is not a pty slave.
      This patch fixes the issue.

 winsup/cygwin/ | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index da75b8dd2..c0015aceb 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -309,7 +309,8 @@ tty_min::setpgid (int pid)
   fhandler_pty_slave *ptys = NULL;
   cygheap_fdenum cfd (false);
   while ( () >= 0 && ptys == NULL)
-    if (cfd->get_device () == getntty ())
+    if (cfd->get_device () == getntty ()
+	&& cfd->get_major () == DEV_PTYS_MAJOR)
       ptys = (fhandler_pty_slave *) (fhandler_base *) cfd;
   if (ptys)

                 reply	other threads:[~2022-02-13 15:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).