public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/cygwin-3_3-branch] Cygwin: console: Revert experimental code mixed accidentally.
@ 2022-02-26 15:36 Takashi Yano
  0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2022-02-26 15:36 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=f6ef457ad212690f16e4ff9bc378944500463d4c

commit f6ef457ad212690f16e4ff9bc378944500463d4c
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Sat Feb 26 23:31:59 2022 +0900

    Cygwin: console: Revert experimental code mixed accidentally.
    
    - The commit "Cygwin: console: Restore CTRL_BREAK_EVENT handling."
      was accidentally mixed with experimental code in exceptions.cc.
      Due to this, non-cygwin app receives CTRL_C_EVENT twice in the
      following scenario.
       1) Run 'sleep 10 | <non-cygwin app>'
       2) Hit Ctrl-C.
       3) The non-cygwin app receives CTRL_C_EVENT twice.
      This patch reverts the code with the problem.

Diff:
---
 winsup/cygwin/exceptions.cc | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc
index 73bf68939..6e0b862c7 100644
--- a/winsup/cygwin/exceptions.cc
+++ b/winsup/cygwin/exceptions.cc
@@ -1174,8 +1174,14 @@ ctrl_c_handler (DWORD type)
        (to indicate that we have handled the signal).  At this point, type
        should be a CTRL_C_EVENT or CTRL_BREAK_EVENT. */
     {
+      int sig = SIGINT;
+      /* If intr and quit are both mapped to ^C, send SIGQUIT on ^BREAK */
+      if (type == CTRL_BREAK_EVENT
+	  && t->ti.c_cc[VINTR] == 3 && t->ti.c_cc[VQUIT] == 3)
+	sig = SIGQUIT;
       t->last_ctrl_c = GetTickCount64 ();
-      fhandler_termios::process_sigs ('\003', (tty *) t, ::cygheap->ctty);
+      t->kill_pgrp (sig);
+      t->output_stopped = false;
       t->last_ctrl_c = GetTickCount64 ();
       return TRUE;
     }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-26 15:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-26 15:36 [newlib-cygwin/cygwin-3_3-branch] Cygwin: console: Revert experimental code mixed accidentally Takashi Yano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).