public inbox for
help / color / mirror / Atom feed
From: Takashi Yano <>
Subject: [newlib-cygwin/cygwin-3_3-branch] Cygwin: console: Correct the past fix for apps which open pty.
Date: Sun, 27 Feb 2022 03:58:53 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=fc2dacb94ab460cfa90492ba9e1410b13d9c6bfc

commit fc2dacb94ab460cfa90492ba9e1410b13d9c6bfc
Author: Takashi Yano <>
Date:   Sun Feb 27 12:33:08 2022 +0900

    Cygwin: console: Correct the past fix for apps which open pty.
    - The commit "Cygwin: console: Fix issues of apps which open pty."
      did not fix the second problem correctly. That commit looked to
      fix the issue, but the actual problem was that ctrl_c_handler()
      should be reregistered *AFTER* FreeConsole()/AttachConsole().
      This patch correct that.

 winsup/cygwin/ | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 568523390..767b28302 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -344,10 +344,10 @@ fhandler_termios::process_sigs (char c, tty* ttyp, fhandler_termios *fh)
 	      (myself->dwProcessId, false);
 	  if (resume_pid && fh && !fh->is_console ())
-	      if (::cygheap->ctty && ::cygheap->ctty->is_console ())
-		init_console_handler (false);
 	      FreeConsole ();
 	      AttachConsole (p->dwProcessId);
+	      if (::cygheap->ctty && ::cygheap->ctty->is_console ())
+		init_console_handler (true);
 	  if (fh && p == myself && being_debugged ())
 	    { /* Avoid deadlock in gdb on console. */

                 reply	other threads:[~2022-02-27  3:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).