public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Takashi Yano <tyan0@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: console: Correct the past fix for apps which open pty. Date: Sun, 27 Feb 2022 03:59:16 +0000 (GMT) [thread overview] Message-ID: <20220227035916.9471C3858D35@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=d857df6f088dc8402ec45bb5a15af2aaca254d64 commit d857df6f088dc8402ec45bb5a15af2aaca254d64 Author: Takashi Yano <takashi.yano@nifty.ne.jp> Date: Sun Feb 27 12:33:08 2022 +0900 Cygwin: console: Correct the past fix for apps which open pty. - The commit "Cygwin: console: Fix issues of apps which open pty." did not fix the second problem correctly. That commit looked to fix the issue, but the actual problem was that ctrl_c_handler() should be reregistered *AFTER* FreeConsole()/AttachConsole(). This patch correct that. Diff: --- winsup/cygwin/fhandler_termios.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/fhandler_termios.cc b/winsup/cygwin/fhandler_termios.cc index 568523390..767b28302 100644 --- a/winsup/cygwin/fhandler_termios.cc +++ b/winsup/cygwin/fhandler_termios.cc @@ -344,10 +344,10 @@ fhandler_termios::process_sigs (char c, tty* ttyp, fhandler_termios *fh) (myself->dwProcessId, false); if (resume_pid && fh && !fh->is_console ()) { - if (::cygheap->ctty && ::cygheap->ctty->is_console ()) - init_console_handler (false); FreeConsole (); AttachConsole (p->dwProcessId); + if (::cygheap->ctty && ::cygheap->ctty->is_console ()) + init_console_handler (true); } if (fh && p == myself && being_debugged ()) { /* Avoid deadlock in gdb on console. */
reply other threads:[~2022-02-27 3:59 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220227035916.9471C3858D35@sourceware.org \ --to=tyan0@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).