public inbox for
help / color / mirror / Atom feed
From: Takashi Yano <>
Subject: [newlib-cygwin] Cygwin: fsync: Return EINVAL for special files.
Date: Mon, 14 Mar 2022 10:40:19 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=af8a7c13b516c77c1e6092157e23ca26db44b1af

commit af8a7c13b516c77c1e6092157e23ca26db44b1af
Author: Takashi Yano <>
Date:   Sat Mar 12 06:19:53 2022 +0900

    Cygwin: fsync: Return EINVAL for special files.
    - Unlike linux, fsync() calls FlushFileBuffers() even for special
      files. This causes the problem reported in:
      This patch fixes the issue.

 winsup/cygwin/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 98d7a3b2d..fc7bf0a0e 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -1750,7 +1750,7 @@ fhandler_base::utimens (const struct timespec *tvp)
 fhandler_base::fsync ()
-  if (!get_handle () || nohandle ())
+  if (!get_handle () || nohandle () || pc.isspecial ())
       set_errno (EINVAL);
       return -1;

                 reply	other threads:[~2022-03-14 10:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).