public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/cygwin-3_3-branch] Cygwin: pty: Do not set internal handles in HPCON inheritable.
@ 2022-04-18 12:02 Takashi Yano
  0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2022-04-18 12:02 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8b9e3ac4080bf34f7b0a6122741ff2f8db810522

commit 8b9e3ac4080bf34f7b0a6122741ff2f8db810522
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Mon Apr 11 10:54:44 2022 +0900

    Cygwin: pty: Do not set internal handles in HPCON inheritable.
    
    - The internal handles in HPCON should not be inheritable, however,
      the current code duplicates them as inheritable when handing over
      ownership of the pseudo console. This patch fixes the issue.
    
    Addresses: https://cygwin.com/pipermail/cygwin/2022-April/251222.html

Diff:
---
 winsup/cygwin/fhandler_tty.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 36992324d..c91f40044 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -2122,7 +2122,7 @@ fhandler_pty_common::resize_pseudo_console (struct winsize *ws)
     OpenProcess (PROCESS_DUP_HANDLE, FALSE, get_ttyp ()->pcon_pid);
   DuplicateHandle (pcon_owner, get_ttyp ()->h_pcon_write_pipe,
 		   GetCurrentProcess (), &hpcon_local.hWritePipe,
-		   0, TRUE, DUPLICATE_SAME_ACCESS);
+		   0, FALSE, DUPLICATE_SAME_ACCESS);
   acquire_attach_mutex (mutex_timeout);
   ResizePseudoConsole ((HPCON) &hpcon_local, size);
   release_attach_mutex ();
@@ -3600,15 +3600,15 @@ fhandler_pty_slave::close_pseudoconsole (tty *ttyp, DWORD force_switch_to)
 	      DuplicateHandle (GetCurrentProcess (),
 			       ttyp->h_pcon_write_pipe,
 			       new_owner, &new_write_pipe,
-			       0, TRUE, DUPLICATE_SAME_ACCESS);
+			       0, FALSE, DUPLICATE_SAME_ACCESS);
 	      DuplicateHandle (GetCurrentProcess (),
 			       ttyp->h_pcon_condrv_reference,
 			       new_owner, &new_condrv_reference,
-			       0, TRUE, DUPLICATE_SAME_ACCESS);
+			       0, FALSE, DUPLICATE_SAME_ACCESS);
 	      DuplicateHandle (GetCurrentProcess (),
 			       ttyp->h_pcon_conhost_process,
 			       new_owner, &new_conhost_process,
-			       0, TRUE, DUPLICATE_SAME_ACCESS);
+			       0, FALSE, DUPLICATE_SAME_ACCESS);
 	      DuplicateHandle (GetCurrentProcess (), ttyp->h_pcon_in,
 			       new_owner, &new_pcon_in,
 			       0, TRUE, DUPLICATE_SAME_ACCESS);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-18 12:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 12:02 [newlib-cygwin/cygwin-3_3-branch] Cygwin: pty: Do not set internal handles in HPCON inheritable Takashi Yano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).