From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2201) id 57C143857342; Wed, 27 Apr 2022 14:05:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57C143857342 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Jon TURNEY To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: Fix build with w32api 10.0.0 X-Act-Checkin: newlib-cygwin X-Git-Author: Jon Turney X-Git-Refname: refs/heads/master X-Git-Oldrev: 21f0edbf9f0efd3d96a83191630eac0eb52726d2 X-Git-Newrev: 0b44b06b0544511bc22352dcff95a216f766f582 Message-Id: <20220427140558.57C143857342@sourceware.org> Date: Wed, 27 Apr 2022 14:05:58 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 14:05:58 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D0b44b06b054= 4511bc22352dcff95a216f766f582 commit 0b44b06b0544511bc22352dcff95a216f766f582 Author: Jon Turney Date: Tue Apr 12 11:41:13 2022 +0100 Cygwin: Fix build with w32api 10.0.0 =20 > ../../../../src/winsup/cygwin/sec_auth.cc:1240:16: error: redefinitio= n of =E2=80=98struct _MSV1_0_S4U_LOGON=E2=80=99 > 1240 | typedef struct _MSV1_0_S4U_LOGON > | ^~~~~~~~~~~~~~~~~ > In file included from ../../../../src/winsup/cygwin/ntsecapi.h:10, > from ../../../../src/winsup/cygwin/sec_auth.cc:13: > /usr/include/w32api/ntsecapi.h:1425:18: note: previous definition of = =E2=80=98struct _MSV1_0_S4U_LOGON=E2=80=99 > 1425 | typedef struct _MSV1_0_S4U_LOGON { > | ^~~~~~~~~~~~~~~~~ > ../../../../src/winsup/cygwin/sec_auth.cc:1246:3: error: conflicting = declaration =E2=80=98typedef int MSV1_0_S4U_LOGON=E2=80=99 > 1246 | } MSV1_0_S4U_LOGON, *PMSV1_0_S4U_LOGON; > | ^~~~~~~~~~~~~~~~ > In file included from ../../../../src/winsup/cygwin/ntsecapi.h:10, > from ../../../../src/winsup/cygwin/sec_auth.cc:13: > /usr/include/w32api/ntsecapi.h:1430:5: note: previous declaration as = =E2=80=98typedef struct _MSV1_0_S4U_LOGON MSV1_0_S4U_LOGON=E2=80=99 > 1430 | } MSV1_0_S4U_LOGON, *PMSV1_0_S4U_LOGON; > | ^~~~~~~~~~~~~~~~ > ../../../../src/winsup/cygwin/sec_auth.cc:1246:22: error: conflicting= declaration =E2=80=98typedef int* PMSV1_0_S4U_LOGON=E2=80=99 > 1246 | } MSV1_0_S4U_LOGON, *PMSV1_0_S4U_LOGON; > | ^~~~~~~~~~~~~~~~~ > In file included from ../../../../src/winsup/cygwin/ntsecapi.h:10, > from ../../../../src/winsup/cygwin/sec_auth.cc:13: > /usr/include/w32api/ntsecapi.h:1430:24: note: previous declaration as= =E2=80=98typedef struct _MSV1_0_S4U_LOGON* PMSV1_0_S4U_LOGON=E2=80=99 > 1430 | } MSV1_0_S4U_LOGON, *PMSV1_0_S4U_LOGON; Diff: --- winsup/cygwin/sec_auth.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/sec_auth.cc b/winsup/cygwin/sec_auth.cc index 121d55e05..0e5aaeb0b 100644 --- a/winsup/cygwin/sec_auth.cc +++ b/winsup/cygwin/sec_auth.cc @@ -1232,8 +1232,9 @@ out: * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ =20 -/* In Mingw-w64, MsV1_0S4ULogon and MSV1_0_S4U_LOGON are only defined - in ddk/ntifs.h. We can't include this. */ +/* In w32api prior to 10.0.0, MsV1_0S4ULogon and MSV1_0_S4U_LOGON are only + defined in ddk/ntifs.h, which we can't include. */ +#if (__MINGW64_VERSION_MAJOR < 10) =20 #define MsV1_0S4ULogon ((MSV1_0_LOGON_SUBMIT_TYPE) 12) =20 @@ -1248,6 +1249,8 @@ typedef struct _MSV1_0_S4U_LOGON /* Missing in Mingw-w64 */ #define KERB_S4U_LOGON_FLAG_IDENTITY 0x08 =20 +#endif + /* If logon is true we need an impersonation token. Otherwise we just need an identification token, e. g. to fetch the group list. */ HANDLE