public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Takashi Yano <tyan0@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: pty: Not to change code page of parent console.
Date: Mon,  9 May 2022 03:54:06 +0000 (GMT)	[thread overview]
Message-ID: <20220509035406.E7A743858C54@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=a19161a6d3f2da706e6a6b3ea026d209848c3ad3

commit a19161a6d3f2da706e6a6b3ea026d209848c3ad3
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Mon May 9 12:23:57 2022 +0900

    Cygwin: pty: Not to change code page of parent console.
    
    - The recent commit "Cygwin: pty: Fix timing of creating invisible
      console." breaks the feature added by commit 72770148, which
      prevents pty from changing code page of parent console. This patch
      restores that.

Diff:
---
 winsup/cygwin/fhandler_console.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 5625b7be2..933614228 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -1610,7 +1610,7 @@ fhandler_console::close ()
   if (con_ra.rabuf)
     free (con_ra.rabuf);
 
-  if (!have_execed)
+  if (!have_execed && !invisible_console)
     free_console ();
   return 0;
 }


                 reply	other threads:[~2022-05-09  3:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509035406.E7A743858C54@sourceware.org \
    --to=tyan0@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).