public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Takashi Yano <tyan0@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: pty: Avoid script command crash in console. Date: Mon, 9 May 2022 11:34:36 +0000 (GMT) [thread overview] Message-ID: <20220509113436.81A7B3858010@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=92b576dcc1577e2484c9ce484baa54de3bb60a55 commit 92b576dcc1577e2484c9ce484baa54de3bb60a55 Author: Takashi Yano <takashi.yano@nifty.ne.jp> Date: Mon May 9 19:45:18 2022 +0900 Cygwin: pty: Avoid script command crash in console. - Previously, script command sometimes crashes by Ctrl-C in Win 7 if it is running in console, and non-cygwin app is foreground. This patch fixes the issue. Diff: --- winsup/cygwin/fhandler_tty.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc index bb18d139e..9dfc3c495 100644 --- a/winsup/cygwin/fhandler_tty.cc +++ b/winsup/cygwin/fhandler_tty.cc @@ -4184,8 +4184,7 @@ fhandler_pty_common::attach_console_temporarily (DWORD target_pid) { FreeConsole (); AttachConsole (target_pid); - init_console_handler (::cygheap->ctty - && ::cygheap->ctty->is_console ()); + init_console_handler (false); } return console_exists ? resume_pid : (DWORD) -1; } @@ -4200,8 +4199,7 @@ fhandler_pty_common::resume_from_temporarily_attach (DWORD resume_pid) if (console_exists) if (!resume_pid || !AttachConsole (resume_pid)) AttachConsole (ATTACH_PARENT_PROCESS); - init_console_handler (::cygheap->ctty - && ::cygheap->ctty->is_console ()); + init_console_handler (false); } release_attach_mutex (); }
reply other threads:[~2022-05-09 11:34 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220509113436.81A7B3858010@sourceware.org \ --to=tyan0@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).