From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2155)
 id 276963943405; Mon, 16 May 2022 16:17:38 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 276963943405
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: document why we can't drop the
 _pei386_runtime_relocator dummy
X-Act-Checkin: newlib-cygwin
X-Git-Author: Corinna Vinschen <corinna@vinschen.de>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: b3b9e231de85eeb574f7bf37d8fdd3c517b853dc
X-Git-Newrev: 83f8e24f0b4a8cd4e03e86320c2647f4bb6939f5
Message-Id: <20220516161738.276963943405@sourceware.org>
Date: Mon, 16 May 2022 16:17:38 +0000 (GMT)
X-BeenThere: cygwin-cvs@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component git logs <cygwin-cvs.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-cvs/>
List-Help: <mailto:cygwin-cvs-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Mon, 16 May 2022 16:17:38 -0000

https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D83f8e24f0b4=
a8cd4e03e86320c2647f4bb6939f5

commit 83f8e24f0b4a8cd4e03e86320c2647f4bb6939f5
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon May 16 17:54:51 2022 +0200

    Cygwin: document why we can't drop the _pei386_runtime_relocator dummy
   =20
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/lib/_cygwin_crt0_common.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/lib/_cygwin_crt0_common.cc b/winsup/cygwin/lib/_=
cygwin_crt0_common.cc
index c9e61ea63..6c51422b8 100644
--- a/winsup/cygwin/lib/_cygwin_crt0_common.cc
+++ b/winsup/cygwin/lib/_cygwin_crt0_common.cc
@@ -170,7 +170,10 @@ _cygwin_crt0_common (MainFunc f, per_process *u)
   u->pseudo_reloc_end =3D &__RUNTIME_PSEUDO_RELOC_LIST_END__;
   u->image_base =3D &_image_base__;
   /* This is actually a dummy call to force the linker to load this
-     symbol for older apps which need it.  */
+     symbol for older apps which need it. Unfortunately, ld for x86_64
+     still emits this symbol when linking against static libs which
+     require pseudo relocation, so we can't drop this call and the
+     dummy function just yet. */
   _pei386_runtime_relocator (NULL);
   return 1;
 }