public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: restore two instances of __stdcall
@ 2022-06-07 17:56 Ken Brown
  0 siblings, 0 replies; only message in thread
From: Ken Brown @ 2022-06-07 17:56 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=07cf7630957e637755b347888bc4d69e5d51aa71

commit 07cf7630957e637755b347888bc4d69e5d51aa71
Author: Ken Brown <kbrown@cornell.edu>
Date:   Tue Jun 7 13:46:31 2022 -0400

    Cygwin: restore two instances of __stdcall
    
    In the previous commit, __stdcall was removed from _dll_crt0 in
    winsup.h and dcrt0.cc but not in lib/cygwin_crt0.c.  For consistency,
    restore the first two occurrences of __stdcall.  We could instead
    remove it from the declaration in lib/cygwin_crt0.c, but this might
    appear to affect binary compatibility, even though it really doesn't.

Diff:
---
 winsup/cygwin/dcrt0.cc | 2 +-
 winsup/cygwin/winsup.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/dcrt0.cc b/winsup/cygwin/dcrt0.cc
index c460e15a0..a8ed8e2fe 100644
--- a/winsup/cygwin/dcrt0.cc
+++ b/winsup/cygwin/dcrt0.cc
@@ -1013,7 +1013,7 @@ __cygwin_exit_return:			\n\
 ");
 }
 
-extern "C" void
+extern "C" void __stdcall
 _dll_crt0 ()
 {
   /* Starting with Windows 10 rel 1511, the main stack of an application is
diff --git a/winsup/cygwin/winsup.h b/winsup/cygwin/winsup.h
index 43dfbf46f..4bcbfde64 100644
--- a/winsup/cygwin/winsup.h
+++ b/winsup/cygwin/winsup.h
@@ -147,7 +147,7 @@ extern int cygserver_running;
 class per_process;
 /* cygwin .dll initialization */
 void dll_crt0 (per_process *) __asm__ (_SYMSTR (dll_crt0__FP11per_process));
-extern "C" void _dll_crt0 ();
+extern "C" void __stdcall _dll_crt0 ();
 void dll_crt0_1 (void *);
 void dll_dllcrt0_1 (void *);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-07 17:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-07 17:56 [newlib-cygwin] Cygwin: restore two instances of __stdcall Ken Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).