public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Takashi Yano <tyan0@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/cygwin-3_3-branch] Cygwin: pty: Treat *.bat and *.cmd as a non-cygwin console app. Date: Sun, 31 Jul 2022 08:57:28 +0000 (GMT) [thread overview] Message-ID: <20220731085728.32E123852752@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=2b4f986e499f040966be72516dae5b01ef721d24 commit 2b4f986e499f040966be72516dae5b01ef721d24 Author: Takashi Yano <takashi.yano@nifty.ne.jp> Date: Sun Jul 31 17:42:00 2022 +0900 Cygwin: pty: Treat *.bat and *.cmd as a non-cygwin console app. - If *.bat or *.cmd is executed directly from cygwin shell, pty failed to switch I/O pipe to that for native apps. This patch fixes the issue. Diff: --- winsup/cygwin/release/3.3.6 | 5 +++++ winsup/cygwin/spawn.cc | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/release/3.3.6 b/winsup/cygwin/release/3.3.6 index 44a7bcf9d..5fb59bf7d 100644 --- a/winsup/cygwin/release/3.3.6 +++ b/winsup/cygwin/release/3.3.6 @@ -26,3 +26,8 @@ Bug Fixes - Fix a console problem that the text longer than 1024 bytes cannot be pasted correctly. Addresses: https://cygwin.com/pipermail/cygwin/2022-June/251764.html + +- Fix a pty problem that pty failed to switch I/O pipe to that for + native apps if *.bat or *.cmd is executed directly from cygwin + shell. + Addresses: https://cygwin.com/pipermail/cygwin/2022-July/251993.html diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc index e0f1247e1..4ec6a8789 100644 --- a/winsup/cygwin/spawn.cc +++ b/winsup/cygwin/spawn.cc @@ -210,7 +210,12 @@ is_console_app (WCHAR *filename) if (p && p + id_offset <= buf + n) return p[id_offset] == '\003'; /* 02: GUI, 03: console */ else - return false; + { + wchar_t *e = wcsrchr (filename, L'.'); + if (e && (wcscasecmp (e, L".bat") == 0 || wcscasecmp (e, L".cmd") == 0)) + return true; + } + return false; } int
reply other threads:[~2022-07-31 8:57 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220731085728.32E123852752@sourceware.org \ --to=tyan0@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).