public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: fix/drop a few comments Date: Wed, 3 Aug 2022 16:15:06 +0000 (GMT) [thread overview] Message-ID: <20220803161506.76A97385828D@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=f418195dc93bb1d0591d43a550586c370facc856 commit f418195dc93bb1d0591d43a550586c370facc856 Author: Corinna Vinschen <corinna@vinschen.de> Date: Wed Aug 3 18:14:39 2022 +0200 Cygwin: fix/drop a few comments Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/include/cygwin/version.h | 3 +-- winsup/cygwin/include/sys/param.h | 1 - winsup/cygwin/mount.cc | 8 ++++---- winsup/cygwin/mount.h | 7 +++---- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/winsup/cygwin/include/cygwin/version.h b/winsup/cygwin/include/cygwin/version.h index c190dc2d6..0eb472ad8 100644 --- a/winsup/cygwin/include/cygwin/version.h +++ b/winsup/cygwin/include/cygwin/version.h @@ -218,8 +218,7 @@ details. */ 143: Export clock_getres, clock_setres 144: Export timelocal, timegm. 145: Add MAP_NORESERVE flag to mmap. - 146: Change SI_USER definition. FIXME: Need to develop compatibility - macro for this? + 146: Change SI_USER definition. 147: Eliminate problematic d_ino from dirent structure. unsetenv now returns int, as per linux. 148: Add open(2) flags O_SYNC, O_RSYNC, O_DSYNC and O_DIRECT. diff --git a/winsup/cygwin/include/sys/param.h b/winsup/cygwin/include/sys/param.h index 742599b8b..b43e29974 100644 --- a/winsup/cygwin/include/sys/param.h +++ b/winsup/cygwin/include/sys/param.h @@ -25,7 +25,6 @@ #define NGROUPS NGROUPS_MAX /* Ticks/second for system calls such as times() */ -/* FIXME: is this the appropriate value? */ #define HZ 1000 /* Max hostname size that can be dealt with (== Win32 MAX_HOSTNAME_LEN) */ diff --git a/winsup/cygwin/mount.cc b/winsup/cygwin/mount.cc index 389f62fad..10574ba58 100644 --- a/winsup/cygwin/mount.cc +++ b/winsup/cygwin/mount.cc @@ -1276,8 +1276,8 @@ static mount_item *mounts_for_sort; /* sort_by_posix_name: qsort callback to sort the mount entries. Sort user mounts ahead of system mounts to the same POSIX path. */ -/* FIXME: should the user should be able to choose whether to - prefer user or system mounts??? */ +/* FIXME: should the user be able to choose whether to prefer user or + system mounts??? */ static int sort_by_posix_name (const void *a, const void *b) { @@ -1312,8 +1312,8 @@ sort_by_posix_name (const void *a, const void *b) /* sort_by_native_name: qsort callback to sort the mount entries. Sort user mounts ahead of system mounts to the same POSIX path. */ -/* FIXME: should the user should be able to choose whether to - prefer user or system mounts??? */ +/* FIXME: should the user be able to choose whether to prefer user or + system mounts??? */ static int sort_by_native_name (const void *a, const void *b) { diff --git a/winsup/cygwin/mount.h b/winsup/cygwin/mount.h index f54516c30..d3e1f1843 100644 --- a/winsup/cygwin/mount.h +++ b/winsup/cygwin/mount.h @@ -152,10 +152,9 @@ class mount_item int build_win32 (char *, const char *, unsigned *, unsigned); }; -/* Warning: Decreasing this value will cause cygwin.dll to ignore existing - higher numbered registry entries. Don't change this number willy-nilly. - What we need is to have a more dynamic allocation scheme, but the current - scheme should be satisfactory for a long while yet. */ +/* Don't change this number willy-nilly. What we need is to have a more + dynamic allocation scheme, but the current scheme should be satisfactory + for a long while yet. */ #define MAX_MOUNTS 64 class reg_key;
reply other threads:[~2022-08-03 16:15 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220803161506.76A97385828D@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).