From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 76A97385828D; Wed, 3 Aug 2022 16:15:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76A97385828D Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: fix/drop a few comments X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: b226e4228a988d273b5214c9f22ecc5d8fa4288f X-Git-Newrev: f418195dc93bb1d0591d43a550586c370facc856 Message-Id: <20220803161506.76A97385828D@sourceware.org> Date: Wed, 3 Aug 2022 16:15:06 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 16:15:06 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3Df418195dc93= bb1d0591d43a550586c370facc856 commit f418195dc93bb1d0591d43a550586c370facc856 Author: Corinna Vinschen Date: Wed Aug 3 18:14:39 2022 +0200 Cygwin: fix/drop a few comments =20 Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/include/cygwin/version.h | 3 +-- winsup/cygwin/include/sys/param.h | 1 - winsup/cygwin/mount.cc | 8 ++++---- winsup/cygwin/mount.h | 7 +++---- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/winsup/cygwin/include/cygwin/version.h b/winsup/cygwin/include= /cygwin/version.h index c190dc2d6..0eb472ad8 100644 --- a/winsup/cygwin/include/cygwin/version.h +++ b/winsup/cygwin/include/cygwin/version.h @@ -218,8 +218,7 @@ details. */ 143: Export clock_getres, clock_setres 144: Export timelocal, timegm. 145: Add MAP_NORESERVE flag to mmap. - 146: Change SI_USER definition. FIXME: Need to develop compatibility - macro for this? + 146: Change SI_USER definition. 147: Eliminate problematic d_ino from dirent structure. unsetenv now returns int, as per linux. 148: Add open(2) flags O_SYNC, O_RSYNC, O_DSYNC and O_DIRECT. diff --git a/winsup/cygwin/include/sys/param.h b/winsup/cygwin/include/sys/= param.h index 742599b8b..b43e29974 100644 --- a/winsup/cygwin/include/sys/param.h +++ b/winsup/cygwin/include/sys/param.h @@ -25,7 +25,6 @@ #define NGROUPS NGROUPS_MAX =20 /* Ticks/second for system calls such as times() */ -/* FIXME: is this the appropriate value? */ #define HZ 1000 =20 /* Max hostname size that can be dealt with (=3D=3D Win32 MAX_HOSTNAME_LEN= ) */ diff --git a/winsup/cygwin/mount.cc b/winsup/cygwin/mount.cc index 389f62fad..10574ba58 100644 --- a/winsup/cygwin/mount.cc +++ b/winsup/cygwin/mount.cc @@ -1276,8 +1276,8 @@ static mount_item *mounts_for_sort; =20 /* sort_by_posix_name: qsort callback to sort the mount entries. Sort user mounts ahead of system mounts to the same POSIX path. */ -/* FIXME: should the user should be able to choose whether to - prefer user or system mounts??? */ +/* FIXME: should the user be able to choose whether to prefer user or + system mounts??? */ static int sort_by_posix_name (const void *a, const void *b) { @@ -1312,8 +1312,8 @@ sort_by_posix_name (const void *a, const void *b) =20 /* sort_by_native_name: qsort callback to sort the mount entries. Sort user mounts ahead of system mounts to the same POSIX path. */ -/* FIXME: should the user should be able to choose whether to - prefer user or system mounts??? */ +/* FIXME: should the user be able to choose whether to prefer user or + system mounts??? */ static int sort_by_native_name (const void *a, const void *b) { diff --git a/winsup/cygwin/mount.h b/winsup/cygwin/mount.h index f54516c30..d3e1f1843 100644 --- a/winsup/cygwin/mount.h +++ b/winsup/cygwin/mount.h @@ -152,10 +152,9 @@ class mount_item int build_win32 (char *, const char *, unsigned *, unsigned); }; =20 -/* Warning: Decreasing this value will cause cygwin.dll to ignore existing - higher numbered registry entries. Don't change this number willy-nilly. - What we need is to have a more dynamic allocation scheme, but the curre= nt - scheme should be satisfactory for a long while yet. */ +/* Don't change this number willy-nilly. What we need is to have a more + dynamic allocation scheme, but the current scheme should be satisfactory + for a long while yet. */ #define MAX_MOUNTS 64 =20 class reg_key;