From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tyan0@sourceware.org>
Received: by sourceware.org (Postfix, from userid 7868)
 id E82333858D37; Fri,  5 Aug 2022 09:04:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E82333858D37
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Takashi Yano <tyan0@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: pty: Fix a small bug in is_console_app().
X-Act-Checkin: newlib-cygwin
X-Git-Author: Takashi Yano <takashi.yano@nifty.ne.jp>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: 58e981a5a42cd46ff52591d0394deeea9d3f01f0
X-Git-Newrev: 249f42d07a447ceb6fe22db5a2570f913cb5b4e5
Message-Id: <20220805090407.E82333858D37@sourceware.org>
Date: Fri,  5 Aug 2022 09:04:07 +0000 (GMT)
X-BeenThere: cygwin-cvs@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component git logs <cygwin-cvs.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-cvs/>
List-Help: <mailto:cygwin-cvs-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-cvs>,
 <mailto:cygwin-cvs-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Fri, 05 Aug 2022 09:04:08 -0000

https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D249f42d07a4=
47ceb6fe22db5a2570f913cb5b4e5

commit 249f42d07a447ceb6fe22db5a2570f913cb5b4e5
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Fri Aug 5 17:53:16 2022 +0900

    Cygwin: pty: Fix a small bug in is_console_app().
   =20
    - Previsouly, there was potential risk of buffer over run in
      is_console_app(). This patch fixes the issue.

Diff:
---
 winsup/cygwin/spawn.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 7de96827c..641f23642 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -224,7 +224,7 @@ is_console_app (WCHAR *filename)
   ReadFile (h, buf, sizeof (buf), &n, 0);
   CloseHandle (h);
   char *p =3D (char *) memmem (buf, n, "PE\0\0", 4);
-  if (p && p + id_offset <=3D buf + n)
+  if (p && p + id_offset < buf + n)
     return p[id_offset] =3D=3D '\003'; /* 02: GUI, 03: console */
   else
     {