public inbox for
help / color / mirror / Atom feed
* [newlib-cygwin] Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'"
@ 2022-10-28 10:49 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2022-10-28 10:49 UTC (permalink / raw)
  To: cygwin-cvs;h=213b53ed355712b97d361a273a87f1162b8b7aab

commit 213b53ed355712b97d361a273a87f1162b8b7aab
Author: Corinna Vinschen <>
Date:   Fri Oct 28 12:24:31 2022 +0200

    Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'"
    This reverts commit 7589034cc3151bfac8cc3d3af5e91402a78e160b.
    The previous commit 14816de9af69 ("Cygwin: spawn: drop special handling
    for cmd.exe and") make this patch unnecessary.  The filename
    argument (i. e., run_path in the caller) is now always non-NULL.
    Signed-off-by: Corinna Vinschen <>

 winsup/cygwin/ | 2 --
 1 file changed, 2 deletions(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index a450ea443..f0ae73999 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -215,8 +215,6 @@ handle (int fd, bool writing)
 static bool
 is_console_app (WCHAR *filename)
-  if (filename == NULL)
-    return true; /* The command executed is or cmd.exe. */
   HANDLE h;
   const int id_offset = 92;
   h = CreateFileW (filename, GENERIC_READ, FILE_SHARE_READ,

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-28 10:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-28 10:49 [newlib-cygwin] Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'" Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).