From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 43EF5385AC2B; Fri, 28 Oct 2022 10:49:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43EF5385AC2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666954170; bh=ak0F0tkycZFAg4bO2QlB7y4AtpIc0/1Eh24deXR/e9g=; h=From:To:Subject:Date:From; b=g83scumoHcRs5NnJDwg6s6LV4f5LyVNObc3C2SuXfOeKvT9aRPxyizbNoLIOfLaNf 02g2gAFT+UoaaQCLTbYHxBqURDdM3TmZ57gJmqP2hsxeL6QzOfWCEZgz7iY6BsXiK6 cWmluQBovRufZCin/JbwKhh/4Otvu1gXje3jwTGY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'" X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: f33635ae607660c3248aafdf8a53e926d41ae45b X-Git-Newrev: 213b53ed355712b97d361a273a87f1162b8b7aab Message-Id: <20221028104930.43EF5385AC2B@sourceware.org> Date: Fri, 28 Oct 2022 10:49:30 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D213b53ed355= 712b97d361a273a87f1162b8b7aab commit 213b53ed355712b97d361a273a87f1162b8b7aab Author: Corinna Vinschen Date: Fri Oct 28 12:24:31 2022 +0200 Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c d= ir'" =20 This reverts commit 7589034cc3151bfac8cc3d3af5e91402a78e160b. =20 The previous commit 14816de9af69 ("Cygwin: spawn: drop special handling for cmd.exe and command.com") make this patch unnecessary. The filename argument (i. e., run_path in the caller) is now always non-NULL. =20 Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/spawn.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc index a450ea443..f0ae73999 100644 --- a/winsup/cygwin/spawn.cc +++ b/winsup/cygwin/spawn.cc @@ -215,8 +215,6 @@ handle (int fd, bool writing) static bool is_console_app (WCHAR *filename) { - if (filename =3D=3D NULL) - return true; /* The command executed is command.com or cmd.exe. */ HANDLE h; const int id_offset =3D 92; h =3D CreateFileW (filename, GENERIC_READ, FILE_SHARE_READ,