public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: memory_layout.h: fix comments
Date: Fri, 28 Oct 2022 14:27:36 +0000 (GMT)	[thread overview]
Message-ID: <20221028142736.B6D30384B82B@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=0508e11f88f73df500f91f75e0314c3592c0526b

commit 0508e11f88f73df500f91f75e0314c3592c0526b
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Wed Oct 26 21:26:37 2022 +0200

    Cygwin: memory_layout.h: fix comments
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/local_includes/memory_layout.h | 22 +++-------------------
 1 file changed, 3 insertions(+), 19 deletions(-)

diff --git a/winsup/cygwin/local_includes/memory_layout.h b/winsup/cygwin/local_includes/memory_layout.h
index 22e68b93e..18e7e4d69 100644
--- a/winsup/cygwin/local_includes/memory_layout.h
+++ b/winsup/cygwin/local_includes/memory_layout.h
@@ -7,24 +7,8 @@ This software is a copyrighted work licensed under the terms of the
 Cygwin license.  Please consult the file "CYGWIN_LICENSE" for
 details. */
 
-/* We use fixed addresses outside the low 32 bit arena, which is exclusively
-   used by the OS now:
-     - The executable starts at 0x1:00400000L
-     - The Cygwin DLL starts at 0x1:80040000L
-     - Rebased DLLs are located from 0x2:00000000L up to 0x4:00000000L
-     - auto-image-based DLLs are located from 0x4:00000000L up to 0x6:00000000L
-     - Thread stacks are located from 0x6:00000000L up to 0x8:00000000L.
-     - So the heap starts at 0x8:00000000L. */
-
-  /* TODO: Make Cygwin work with ASLR.
-     - The executable starts at 0x1:00400000L
-     - Rebased non-ASLRed DLLs from 0x2:00000000L up to 0x4:00000000L
-     - auto-image-based non-ASLRed DLLs from 0x4:00000000L up to 0x6:00000000L
-     - Thread stacks are located from 0x6:00000000L up to 0x8:00000000L.
-     - cygheap from 0x8:00000000L up to 0xa:00000000L.
-     - So the heap starts at 0xa:00000000L. */
-
-/* This is where the Cygwin executables are loaded to. */
+/* This is where Cygwin executables are loaded to, unless dynamicbase is
+   enabled in the PE/COFF header of the executable file. */
 #define EXECUTABLE_ADDRESS		0x100400000UL
 
 /* Fixed address set by the linker. The Cygwin DLL will have this address set
@@ -64,7 +48,7 @@ details. */
 
 /* This is where the user heap starts.  There's no defined end address.
    The user heap pontentially grows into the mmap arena.  However,
-   the user heap grows upwar4ds and the mmap arena grows downwards,
+   the user heap grows upwards and the mmap arena grows downwards,
    so there's not much chance to meet unluckily. */
 #define USERHEAP_START			0xa00000000UL

                 reply	other threads:[~2022-10-28 14:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028142736.B6D30384B82B@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).