public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: Handle out of order modules for module offsets in stackdump Date: Fri, 4 Nov 2022 15:11:31 +0000 (GMT) [thread overview] Message-ID: <20221104151131.CE20A385843B@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=564c88b89833d711281f7b5dd2b74b453dc66ea9 commit 564c88b89833d711281f7b5dd2b74b453dc66ea9 Author: Jon Turney <jon.turney@dronecode.org.uk> Date: Tue Nov 1 14:01:08 2022 +0000 Cygwin: Handle out of order modules for module offsets in stackdump Improve address to module+offset conversion, to work correctly in the presence of out-of-order elements in InMemoryOrderModuleList. Fixes: d59651d4 Diff: --- winsup/cygwin/exceptions.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc index 8cc454c90..c3433ab94 100644 --- a/winsup/cygwin/exceptions.cc +++ b/winsup/cygwin/exceptions.cc @@ -342,11 +342,13 @@ prettyprint_va (PVOID func_va) { PLDR_DATA_TABLE_ENTRY mod = CONTAINING_RECORD (x, LDR_DATA_TABLE_ENTRY, InMemoryOrderLinks); - if (mod->DllBase > func_va) + if ((func_va < mod->DllBase) || + (func_va > (PVOID)((DWORD_PTR)mod->DllBase + mod->SizeOfImage))) continue; __small_sprintf (buf, "%S+0x%x", &mod->BaseDllName, (DWORD_PTR)func_va - (DWORD_PTR)mod->DllBase); + break; } return buf;
reply other threads:[~2022-11-04 15:11 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221104151131.CE20A385843B@sourceware.org \ --to=jturney@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).