public inbox for firstname.lastname@example.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: rename __sFILE to __sFILE64 for backward compatibility
@ 2022-12-08 13:17 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2022-12-08 13:17 UTC (permalink / raw)
Author: Corinna Vinschen <email@example.com>
AuthorDate: Thu Dec 8 13:58:37 2022 +0100
Commit: Corinna Vinschen <firstname.lastname@example.org>
CommitDate: Thu Dec 8 13:58:37 2022 +0100
Cygwin: rename __sFILE to __sFILE64 for backward compatibility
Until Cygwin 3.3.6, we define __LARGE64_FILES unconditionally, so we
were using the type __sFILE64 even for 64 bit. That was lazy and wrong.
so commit 2902b3a09e0a ("Cygwin: drop requirement to build newlib's
stdio64") tried to fix that.
Unfortunately this patch forgot to take the exposure of the typename
__sFILE64 in userspace into account. This leads to trouble in C++ due
to name mangling.
Fix this by redefining __sFILE to __sFILE64. The type name is very much
internal, so it doesn't really matter, except for the fact that it needs
to stay backward compatible so as not to break building against C++ libs
built under older versions of Cygwin.
Fixes: 2902b3a09e0a ("Cygwin: drop requirement to build newlib's stdio64")
Signed-off-by: Corinna Vinschen <email@example.com>
winsup/cygwin/include/cygwin/config.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/winsup/cygwin/include/cygwin/config.h b/winsup/cygwin/include/cygwin/config.h
index 2a708327890b..c9c3565c63a3 100644
@@ -49,6 +49,12 @@ extern inline struct _reent *__getreent (void)
#define __FILENAME_MAX__ 4096 /* Keep in sync with PATH_MAX in limits.h. */
+/* Unfortunately we defined __LARGE64_FILES until Cygwin 3.3.6, so
+ FILE was based on `struct __sFILE64'. The name is exposed into
+ userspace and consequentially used in C++ name mangling. We must
+ redefine __sFILE as __sFILE64 to stay backward compatible. */
+#define __sFILE __sFILE64
/* The following block of macros is required to build newlib correctly for
Cygwin. Changing them in applications has no or not the desired effect.
Just leave them alone. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-08 13:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-08 13:17 [newlib-cygwin] Cygwin: rename __sFILE to __sFILE64 for backward compatibility Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).